judyfong
commented
3 years ago Should smari be the reviewer? He’s reviewed all the other PR until now.
On Wednesday, September 29, 2021, staffanru @.***> wrote:
@staffanru https://github.com/staffanru requested your review on: #134 https://github.com/cadia-lvl/samromur/pull/134 Improved authentication.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/cadia-lvl/samromur/pull/134#event-5382066538, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUMNYHIUWYSI4LHEILFADTUEM5JVANCNFSM5FAJOZTQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
staffanru
Improves authentication as discussed.
Added new auth error for those who should replace their password (won't be able to sign in unless they do)
Had to update the reset password functionality as well, improved the form with some feedback that it is loading (with improved security comes longer waiting time to sign in, so feedback was good)
Many db calls can no longer rely on db queries. But need to get a result and compare so each had to be updated accordingly.