Closed 17luke closed 1 month ago
Btw why is there a hyphen in your commit message? That is improper commit message formatting in my opinion. Also I hope your commit message has a short description of the changes.
Best regards,
Judy
P.S. For needing to teach you this myself instead of your employer teaching you this, I request a 12.000 ISK total consulting fee from your employer because they are offloading the teaching of proper coding practices to someone else. I charge a 12.000 hourly minimum to companies like your employer and its board of directors. Luke, please let me know if you will forward this message to them as I am not interested in working for your employer for free anymore. Thank you.
The first line is the title and the rest of the lines starting with line 2 are the description.
On Wednesday, August 14, 2024, 17luke @.***> wrote:
@thdg https://github.com/thdg Makes formatting the same when navigating to l2 page from front page and when opening l2 page by url.
You can view, comment on, or merge this pull request online at:
https://github.com/cadia-lvl/samromur/pull/151 Commit Summary
- 6cb5556 https://github.com/cadia-lvl/samromur/pull/151/commits/6cb55568cd9b21f4d04b759b06c627f86fec5fd0 workaround - fix formatting when opening l2 page by url.
File Changes
(1 file https://github.com/cadia-lvl/samromur/pull/151/files)
- M src/components/subpages/l2-sign-in-hello.tsx https://github.com/cadia-lvl/samromur/pull/151/files#diff-3e3d03af1b959b319586817d0a8562fe05fc93246e8e5e255954ec875a1151c0 (12)
Patch Links:
- https://github.com/cadia-lvl/samromur/pull/151.patch
- https://github.com/cadia-lvl/samromur/pull/151.diff
— Reply to this email directly, view it on GitHub https://github.com/cadia-lvl/samromur/pull/151, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUMNYHIBETEVXT2PAZQY33ZROBSXAVCNFSM6AAAAABMQWUG76VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DMMZQHAYDCOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Looks good
@thdg Makes formatting the same when navigating to l2 page from front page and when opening l2 page by url.