search

cadia-lvl / samromur

https://samromur.is/
MIT License
2 stars 2 forks source link

Lendingarsidur texts #153

Closed 17luke closed 1 month ago

17luke commented 2 months ago

@thdg Can you review? These are the changes requested by Anna and Bjarni.

SmariF89 commented 2 months ago

Did some code review. Please address the prettier issues as well.

17luke commented 2 months ago

Thanks! I've made all those changes except the prettier formatting. Prettier format check is only failing on some other files in the repo that seem to be a few months old. I'll fix them in a separate PR.

Excerpt from Prettier format check log:

[warn] src/components/contribute/setup/contribute.tsx [warn] src/components/contribute/setup/demographic-form.tsx [warn] src/pages/api/contribute/upload.ts [warn] src/pages/api/stats/user-l2.ts [warn] src/server/database/sentences.ts [warn] src/services/contribute-api.ts [warn] src/services/stats-api.ts [warn] src/store/user/reducer.ts [warn] src/utilities/subpage-helper.ts

17luke commented 2 months ago

Separate PR for prettier format check: https://github.com/cadia-lvl/samromur/pull/155

17luke commented 2 months ago

Think all is resolved now