search

cadia-lvl / samromur

https://samromur.is/
MIT License
2 stars 2 forks source link

Misleading error message #98

Closed SmariF89 closed 2 years ago

SmariF89 commented 3 years ago 
case FormError.INVALID_USERNAME:
    return 'Aðeins bókstafir, bandstrik og undirstrik eru leyfileg. Lágmark 5 stafir.';

People tend to believe that this error message is referring to their password. I ran into this myself and was over 15 minutes to pick a password while it was complaining about my username the whole time. :P

https://github.com/cadia-lvl/samromur/blob/adaa1d3cbd4d119684a0fa5331fc06fc5658298c/src/components/login/login-form.tsx#L161

judyfong commented 3 years ago

haha true

SmariF89 commented 3 years ago

I had totally forgotten about this. What is your opinion on this @staffanru ?

staffanru commented 3 years ago

That this should be fixed and made clear to the user which field it refers to.