cadmiumcr / cadmium

Natural Language Processing (NLP) library for Crystal
https://cadmiumcr.com
MIT License
205 stars 15 forks source link

Adds smog readability test #15

Closed rmarronnier closed 5 years ago

rmarronnier commented 5 years ago

I wanted to set the smog grade to nil or a string The text has less than 30 sentences but the report method doesn't allow it. So I settled on 0.

watzon commented 5 years ago

Please be sure to include specs. Thanks for this!

rmarronnier commented 5 years ago

There are no existing readability specs or I couldn't find any. Do you want me to create a readability.cr specs file ? And I think I'd better create one single PR for the added tests. It'll be much clearer. WDYT ?

watzon commented 5 years ago

hmm I thought I had readability tests. I'll add some so that you can just add to the file per PR. I'd rather have tests and features merged at the same time.

rmarronnier commented 5 years ago

OK, nice.