cadop / dhart

A library for creating Navigation Graphs, Visibility graphs, Raycasting used in design analysis, architecture, robotics, and human factors.
https://cadop.github.io/dhart/
GNU General Public License v3.0
13 stars 8 forks source link

Add overloads for C# Interface to use flat vector with `unsafe` to speedup passing rays #41

Closed mariuszhermansdorfer closed 1 year ago

mariuszhermansdorfer commented 1 year ago

This PR has a bunch of minor optimizations to the raycasting API:

Test results: image

cadop commented 1 year ago

Is there something in your gitignore or a missing commit? I can't build this branch

image

mariuszhermansdorfer commented 1 year ago

Try building it now @cadop.

I reverted all classes back to static and added the missing reference to CMakeLists. Previously I had it added manually here: image

cadop commented 1 year ago

When you get a chance could you edit the original comment for this PR and paste a screenshot of the hfcsharptest group all passing. I need to setup the automated testing on github runners, but until that happens, i'll just need to have people post that the unittests pass, and then ill review the code and test on other platforms.

mariuszhermansdorfer commented 1 year ago

When you get a chance could you edit the original comment for this PR and paste a screenshot of the hfcsharptest group all passing. I need to setup the automated testing on github runners, but until that happens, i'll just need to have people post that the unittests pass, and then ill review the code and test on other platforms.

Updated the initial comment and added a screenshot of all tests passing.

cadop commented 1 year ago

Didn't mean to close this, it was because I deleted the other branch when merging it. You can rebase on main and reopen this PR to be merged into main (and ill change it).