search

cadop / dhart

A library for creating Navigation Graphs, Visibility graphs, Raycasting used in design analysis, architecture, robotics, and human factors.
https://cadop.github.io/dhart/
GNU General Public License v3.0
13 stars 8 forks source link

Typo #include <corecrt_math_defines.h> #70

Closed apric0ts closed 3 months ago

apric0ts commented 3 months ago

Main branch: src/Cpp/objloader/src/meshinfo.cpp https://github.com/cadop/dhart/blob/7ce7a6a84c33dd2c0dbd85effdc380f02cac08d9/src/Cpp/objloader/src/meshinfo.cpp#L12

Dev branch: src/Cpp/objloader/src/meshinfo.cpp https://github.com/cadop/dhart/blob/194b2b37dd47e6a2d7a545a10136e95aa2b5829b/src/Cpp/objloader/src/meshinfo.cpp#L12

Same typo also exists in Cpp/raytracer/src/embree_raytracer.cpp and Cpp/raytracer/src/embree_raytracer.h

Does this corecrt_math_defines.h file exist within the repo?

apric0ts commented 3 months ago

https://github.com/tpn/winsdk-10/blob/master/Include/10.0.16299.0/ucrt/corecrt_math.h

That is intended (part of msvc)