component 1 (joint_order) doesn't work

cadop / fusion360descriptor

A URDF Exporter for Fusion 360

11 stars 3 forks source link

component 1 (joint_order) doesn't work #3

Closed simjeh closed 2 years ago

simjeh commented 2 years ago

The first case had a problem with the joint order. UI's component 1 doesn't work. review is working well. So if the robot model joint in fusion has component1 as a child link then always works. So UI doesn't make a different result. Could you check it? I found the comment about it. https://github.com/cadop/fusion360xml/blob/c63b5ddf8c9fb6e408efd490b80aa9175c6da2a1/Descriptor/core/parser.py#L276

cadop commented 2 years ago

Well really that should say # TODO: Reverse parent and child because I never implemented it. Just to be clear, this will consider the reverse for all joint configurations, not just one. Thats the expected behavior yes?

simjeh commented 2 years ago

If it is controlled by UI then yes. So anyway people keep their own order parent to child or child to parent then it will work. Or we just delete the "component 1" of GUI. And let people follow the child to parent joint order. I don't mind any options.

cadop commented 2 years ago

I will implement it (I did plan to)