search

cadop / seg1d

Automated segmentation of one-dimensional (1D) data
https://cadop.github.io/seg1d/
MIT License
20 stars 2 forks source link

[Joss Review] Update gitignore #2

Closed AKuederle closed 4 years ago

AKuederle commented 4 years ago

The repository contains a couple of file that usually should not be tracked by git.

This includes:

More information on how to do this can be found here: https://www.git-tower.com/learn/git/faq/ignore-tracked-files-in-git

cadop commented 4 years ago

Hi @AKuederle , thanks for reviewing. I removed the files for dist and egg, and added them to git ignore: https://github.com/cadop/seg1d/commit/4381eea8a7347feb5f06d417682aa86a74be278b

However, I can't remove the docs/build because this is the folder github is using to generate the website (its one of three options): https://help.github.com/en/github/working-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#choosing-a-publishing-source

AKuederle commented 4 years ago

Ah I see :) this is indeed not possible in this case. Maybe you could think about publishing the docs via readthedocs in the future? Definitely nothing that should block this review of course.

Feel free to close the issue :)

On Tue, Jun 30, 2020, 02:34 cadop notifications@github.com wrote:

Hi @AKuederle https://github.com/AKuederle , thanks for reviewing. I removed the files for dist and egg, and added them to git ignore.

However, I can't remove the docs/build because this is the folder github is using to generate the website (its one of three options): https://help.github.com/en/github/working-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#choosing-a-publishing-source

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cadop/seg1d/issues/2#issuecomment-651443577, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSHBO4MJHIZ2X7YOQ4UIWTRZEXH3ANCNFSM4OLRDDLQ .

cadop commented 4 years ago

I will revisit the option for make a separate branch if the issue is about pulling the documentation. It is just difficult to maintain for me when I did it before. Ill close this one, but just make a new issue for myself.