search

caduandrade / multi_split_view

Provides horizontal or vertical multiple split view for Flutter.
https://caduandrade.github.io/multi_split_view/
MIT License
129 stars 24 forks source link

MultiSplitViewController should copy weights array #5

Closed sgehrman closed 2 years ago

sgehrman commented 2 years ago

I was passing in the weights, but it was a const [x,y,z]. When the controller tries to modify it, it fails.

I'm wrapping the MultiSplitView in another Widget that is a const widget, and the linter wants me to pass in a const [], so that's why I did that.

Work around for now is: MultiSplitViewController(weights: List.from(widget.weights));

I recommend you turn on the the linter with all the strict settings and clean up the code to make sure it's solid. I don't see that setup in the repo. Maybe it will help.

caduandrade commented 2 years ago

Perfect! I will do this after your PR from the other Issue ok? To avoid conflicts.