caduandrade / multi_split_view

Provides horizontal or vertical multiple split view for Flutter.
MIT License
152 stars 29 forks source link

Issue with the copyWith Function in the Area Class #93

Closed stan-at-work closed 1 month ago

stan-at-work commented 1 month ago

Issue with the copyWith Function in the Area Class

The current implementation of the copyWith function in the Area class is flawed. Specifically, it does not handle null values correctly when passed as parameters.

Problem Description

The current copyWith function in the Area class does not allow null values to be used as arguments. This limitation is problematic because it restricts the flexibility of the function, making it less useful in scenarios where null might be a legitimate value to signify the absence of data or the need to reset a property.

Importance of Handling null Values

In many programming scenarios, the ability to pass null as a parameter is crucial. This functionality is commonly required to reset or clear a property value within a class. By allowing null values, the copyWith function can provide more comprehensive and versatile behavior, aligning with common programming practices and user expectations.

Reference

For more information and a potential solution, you can refer to the discussion on Stack Overflow. This discussion provides insights into implementing a copyWith method that can handle nullable properties effectively.

By addressing this issue, the copyWith function in the Area class can be made more robust and adaptable, thereby improving the overall utility and reliability of the class.

caduandrade commented 1 month ago

Thanks @stan-at-work!

It would be so nice if everyone described the issues so well... :smile:

I will also add tests nullifying values.

stan-at-work commented 1 month ago

@caduandrade Thank for the quick response.

Is it also posible to update the version on pub dev?

caduandrade commented 1 month ago

I will :+1:. I'm adding tests that nullify values ​​and fixing the method. There is still a bug to replace flex with size for example.

caduandrade commented 1 month ago

Version 3.5.0 released. Minor version increment given the API change. Thanks! :+1: