search

caduandrade / tabbed_view

Widget inspired by the classic Desktop-style tab component.
MIT License
51 stars 16 forks source link

Error: 'MenuThemeData' is imported from both 'package:flutter/src/material/menu_theme.dart' and 'package:tabbed_view/src/theme/menu_theme_data.dart' #15

Closed ghost closed 2 years ago

ghost commented 2 years ago

If we were using the Flutter version 3.4.0-36.0.pre.5 on channel master and it caused the build error below :

""flutter-build": Error: 'MenuThemeData' is imported from both 'package:flutter/src/material/menu_theme.dart' and 'package:tabbed_view/src/theme/menu_theme_data.dart'."

So we revert back the flutter version to stable (Flutter 3.3.3 • channel stable • https://github.com/flutter/flutter.git) , then it's working without any issues.

So the issue is once the new code get merged into the stable version we will face the same issue again with tabbed_view ?

caduandrade commented 2 years ago

Hi @avmakesh ! I will take a look.

caduandrade commented 2 years ago

The name 'MenuThemeData' is defined in the libraries 'package:flutter/src/material/menu_theme.dart (via package:flutter/material.dart)' and 'package:tabbed_view/src/theme/menu_theme_data.dart (via package:tabbed_view/tabbed_view.dart)'.

The new Flutter version also has a class with the same name.

caduandrade commented 2 years ago

To avoid conflict and having to import using "as", I'm going to rename MenuThemeData to TabbedViewMenuThemeData.

ghost commented 2 years ago

To avoid conflict and having to import using "as", I'm going to rename MenuThemeData to TabbedViewMenuThemeData.

When we can expect the new version ?

caduandrade commented 2 years ago

When we can expect the new version ?

In the next 122 seconds. :smile:

caduandrade commented 2 years ago

@avmakesh, done. Version 1.14.0. If you have another problem, let me know.

ghost commented 2 years ago

Sure, Thank you.