search

caeleel / twitch-dvr

A chrome extension to enable DVR on Twitch streams.
38 stars 4 forks source link

Clipping is broken + suggestions #8

Closed TBloop closed 2 years ago

TBloop commented 3 years ago

Hi there,

Your extension is much needed and I cant believe twitch hasn't implemented it yet.

Clipping is currently broken, no matter which channel im on and whether an ad is playing or not it gives the error message. Is this fixable?

Also is it possible to add a theater mode button? I know you can use the shortcut but its a lot nicer to have the button.

Thank you!

edit: Also the clipping button goes away when you rewind. Is it possible to still have it if you are not live? Very often I will want to clip something that happened previously - if this extension can't do it then I'd have to just go to the VOD anyways which defeats the point of it.

caeleel commented 2 years ago

Thank you! I fixed the live clip button in the latest release (waiting to be approved by chrome). For clipping in a VOD, I haven't quite figured out the clip API yet. I'll think about it!

TBloop commented 2 years ago

Nice! Any chance about the theatre button? Could you make it just simulate the commands for the theatre mode on the keyboard?

Also, it no longer works when the vod is deleted/hidden. Is it possible for the extension to use the URL for the vod? I know its possible to get links to hidden vods and play them in VLC (.m3u8 files).

I should also note that it seems to have poor compatibility with "Video adblock for twitch" extension. I'll try to switch to the DVR player, and I can hear an ad playing but no video. Even if I wait til the ad is over, it still wont ever switch over to the DVR player. I think the extension may only work on channels I'm subbed to.

Thanks again!

caeleel commented 2 years ago

I fixed clipping in VOD mode in the latest release (should be coming out soon).

hm, for deleted and hidden vods, I don't think that the video urls are deterministic so I don't think I can get the video URL without calling twitch's api (which doesn't return deleted VODs). I could definitely be wrong though.

As for compatibility with video adblock for twitch, as an ex-twitch employee I unfortunately don't feel super comfortable explicitly supporting compatibility with that extension, I'm sorry :(.