search

caelum / vraptor-scaffold

VRaptor Scaffold extension to make it easier configuring new projects and plugins
http://vraptor.org
MIT License
55 stars 22 forks source link

Customizing Generators - issues #28 #71

Closed laeciofreitas closed 12 years ago

laeciofreitas commented 12 years ago

vraptor-scaffold search for templates in other paths.

name_app/src/templates/controller/ controller.erb or controller_test.erb

name_app/src/templates/model/ ..

name_app/src/templates/repository/ ...

name_app/src/templates/engine/ new.erb ....

rodolfoliviero commented 12 years ago

this patch looks good. I will review asap. Thanks

rodolfoliviero commented 12 years ago

@laeciofreitas may you change the latest commits to another branch? If i merge it now i will include some features that are in progress.

laeciofreitas commented 12 years ago

which branch to send the commits?

rodolfoliviero commented 12 years ago

Every time you open a pull request all the new commits that you push to branch automatically will be send to be merge. So i suggest you to create a new branch for every feature that you want to be merged.

In this case can you have a branch called 'customizing-generators' only wich this commit https://github.com/laeciofreitas/vraptor-scaffold/commit/3a459122716cd8f452719155209e85ad1dcbcae2

and commit to this branch only the changes about 'customizing generators' like change the engine source path to 'src/templates/views'.

So you can have another branch called ''new-attributes' or something like that and put the another commits there and when you finish this feature you open a new pull request form this branch

Now i will merge the first commit manually and ask you to open another pull request with the changes that i'd like?

Ok for you?

rodolfoliviero commented 12 years ago

I just pushed to master this commit 'support for customizing generators' manually. So closing this pull request Thanks.

laeciofreitas commented 12 years ago

also close the issue 28.