search

caemor / epd-waveshare

Drivers for various EPDs from Waveshare and others
ISC License
226 stars 136 forks source link

Make Display more generic and remove lot of redundant code #123

Closed peckpeck closed 1 year ago

peckpeck commented 2 years ago

As suggested in #121

caemor commented 2 years ago

Thanks for the great PR(s)! :partying_face:

I just took a quick glance and it looks mostly very good. Just to make it easier to review and to make it easier to assert that nothing changed for the different displays: Could you move a few of the testcases respective 'graphics' file to the 'mod' files?

peckpeck commented 2 years ago

Fixed, and also fixed a bug that made Tricolor case fail

peckpeck commented 1 year ago

Any news on this ?

caemor commented 1 year ago

Thanks for your great work here! That is a major improvement!