search

caeruleusDraconis / world-preview

Apache License 2.0
22 stars 4 forks source link

Add compatibility with Xaero's Mini/WorldMap #4

Closed craftish37 closed 1 year ago

craftish37 commented 1 year ago

While biomes may be difficult to implement as an overlay, structures or just right-clicking in the previewer to add a waypoint may be a good idea

Many other features may be addable in the future if you have any other idea ^^

caeruleusDraconis commented 1 year ago

This is unlikely to happen, since Xaero's Mini/WorldMap is closed source and (at least as far as I can tell) does not offer an API for adding waypoints / overlays. So, for this to happen we would need the support / permission of xaero96 and a public API to interface with the mod.

Basically something similar to https://github.com/TeamJM/journeymap-api but for Xaero's Mini/WorldMap.

That being said, adding features for specific mods is very low on our priority list.

Also, #3 must be first implemented before even considering supporting this.

craftish37 commented 1 year ago

I do agree with your points, since it's closed source, developpment may be harder However, I saw some other mods on modrinth implementing features to those mods and I believe there are ways to get there

https://github.com/plusls/xaero-map-addition https://github.com/Abbie5/xaeroarrowfix https://github.com/rfresh2/XaeroPlus/ https://github.com/NotRyken/XaeroZoomout

caeruleusDraconis commented 1 year ago

I had a quick look at these mods, and what they all have in common are that they are basically mods for Xaero's Min/WorldMap the same way that Xaero's Min/WorldMap is a mod for Minecraft.

They use the same mixin mechanism world-preview and other fabric mods use to modify Minecraft, to modify the Xaero's Min/WorldMap mod instead.

See MinimapRendererMixin.java of https://github.com/Abbie5/xaeroarrowfix for instance.

So, if I would decide to mod Xaero's Min/WorldMap there would be no stability guarantees for new versions and I would possibly spend a considerable amount of time staying compatible with Xaero's Min/WorldMap on top of staying compatible with future versions of Minecraft...

This is not something that I would be willing to implement, let alone maintain.

So, unless xaero96 provides a public API this is not going to happen.