Tree.__contains__ rationale

caesar0301 / treelib

An efficient implementation of tree data structure in python 2/3.

http://treelib.readthedocs.io/en/latest/

Other

801 stars 185 forks source link

Closed cowo78 closed 4 years ago

cowo78 commented 5 years ago

I see that Tree.__contains__ current implementation is:

return [node for node in self._nodes
            if node == identifier]

If I am not mistaken this:

visits every node, which is unnecessary since we can simply lookup the identifier
returns a list while object.__contains__ is only expected to return True or False

This is also trivial to fix and I can provide a patch, unless there's something I am missing

leonardbinet commented 4 years ago