search

caewok / fvtt-token-visibility

Advanced token visibility rules for Foundry VTT
MIT License
4 stars 8 forks source link

Live token cover set to flat but still problematic #66

Closed MotoMoto1234 closed 7 months ago

MotoMoto1234 commented 10 months ago

It seems the percentage of cover on adjacent tokens is set too high or something, I would not rule the coverage this narrow for cover:

adjacent token cover issue.webm

The clip has the side effect of the drag ruler not snapping so its a lil misleading but it still visible here. It feels like the non cover token spread should be 1 more token out when comparing cover:

image

MotoMoto1234 commented 10 months ago

Heres the extreme example:

image

And to confirm its not tactical grid shennanigans:

image

MotoMoto1234 commented 10 months ago

If you have a combination of settings that could fix this let me know I've pretty much tried every combo.

caewok commented 9 months ago

This appears to be working as expected. I see what you mean, but not sure I completely agree that no one should have cover in a tight formation like this.

If you use only the center point of the target to calculate cover, that would mostly address this.

For the upcoming v0.6.0, there is an option to use front-facing corners only in the Points algorithm. I think that would address this issue.

For other points options and for the Area3d algorithm, I don't see a great solution. I could add a toggle to ignore "adjacent" tokens, but under what conditions? Presumably you would consider a token to have cover if it is directly behind another token. So how do I know when a token should be considered to no longer provide cover? Keep in mind that this line formation could be diagonal or otherwise staggered, and we would want a consistent result as the line formation rotates.

caewok commented 7 months ago

Mostly addressed in v0.6 series. But see issue #77.