search

caewok / fvtt-token-visibility

Advanced token visibility rules for Foundry VTT
MIT License
4 stars 8 forks source link

Token Scale throws off cover calc #69

Closed ctbritt closed 9 months ago

ctbritt commented 10 months ago

If a token is scaled it will throw off the cover calc. For instance, using FA Tokens, which are often scaled to 3x for visual effects, makes ATV think the actual creature is VERY BIG and thus, it's not afforded the correct cover.

Example: An orc war priest, which is medium sized, has. FA token that is set to be scaled at 3x. Its computed height is 15 feet, and thus, intervening tokens don't give cover.

Normal 1x scale: image

3x scale: image

3x token scale. you can see the intervening tokens don't give cover as they should CleanShot_2023-11-08_at_16 49 58

Back to 1x scale and all works ok CleanShot_2023-11-08_at_16 51 26

ctbritt commented 10 months ago

Seems to be related to Wall Height somehow. If I set the height of the token manually, it works ok.

caewok commented 9 months ago

That's not really a bug. It is correctly determining that a 15' token does not get the same cover as a 5' token. It uses scaling to determine this because the Wall Height module has long used scaling to determine height. As you noted, you can manually set the height of the token to overcome this.

Using "medium sized" is very problematic, because that is system-specific. I am not saying that basing token height on scaling is ideal, however. Ultimately, I would prefer to see Foundry add a token height parameter that systems could then modify as makes sense for each system. For dnd5e, that would likely be based on creature size.

I will close this and add a new feature request to ignore Wall Height and instead use system-specific sizing. Not promising I will do this soon, but I understand the confusion here.