search

cafana / OscLib

1 stars 8 forks source link

Tweaks for building on Darwin (M1) #7

Open luketpickering opened 2 years ago

cjbacchus commented 2 years ago

Why all the changes to _sincos()? Why not put a definition of sincos() in terms of __sincos() inside an if-apple test, same as with the stan implementation? That would lead to less churn, and less need to remember that we did something weird because Apple.

cjbacchus commented 2 years ago

I cherry-picked all the non-sincos parts of this into https://github.com/cafana/OscLib/pull/10 and added my own sincos solution. If that looks good, I will merge that one.

Except, we still need a generic solution for finding the ROOT library directory. If you can commit a fix for that somewhere I will patch up the branch.