cafebazaar / Poolakey

Android In-App Billing SDK for Cafe Bazaar App Store
Apache License 2.0
71 stars 22 forks source link

Inconsistent Behavior between poolakey and poolakey-rx error handling #19

Closed DHosseiny closed 4 years ago

DHosseiny commented 4 years ago

When normal 'purchaseProduct' function called and an error happened 'failedToBeginFlow' called and because by default 'failedToBeginFlow' is doing nothing so no error is thrown. But when poolakey-rx 'purchaseProduct' function called and an error happened Rx onError get called and if error not handled exception will be thrown. This is inconsistent behavior. This issue exists for 'onActivityResult', 'connect' and other Rx methods. My recommendation is to force the client to handle errors in poolakey, Or throw an error and document it. I like the prior one. What is your idea?