search

caffeinalab / ti.goosh

GCM/FCM module for Titanium.
MIT License
52 stars 34 forks source link

Android Oreo NotificationChannel support #97

Open m1ga opened 6 years ago

m1ga commented 6 years ago

In Ti-Slack someone mentioned, that there could be problems with push under Oreo: missing NotificationChannel. It is related to this SO thread: https://stackoverflow.com/questions/45711925/failed-to-post-notification-on-channel-null-target-api-is-26

Since I don't have an Oreo phone yet I can't prove this but it something that should be on the roadmap if the problem exists in Ti.Goosh too

caioiglesias commented 6 years ago

I have verified this, and it's indeed an issue. I've patched it for now, but the best thing would be to expose the full functionality of the channels.

kopiro commented 6 years ago

How did you fix?

caioiglesias commented 6 years ago

I'll submit a PR so you can check it out, but It's not the optimal solution for the use of channels.

slash-84 commented 6 years ago

I added a (very :) ) little support for Oreo: https://github.com/caffeinalab/ti.goosh/pull/102

caioiglesias commented 6 years ago

That's pretty much how I did it @slash-84

sandrolain commented 6 years ago

Hello to all. I'm having trouble with notifications on any Android 8.0 device that I've run my app with the version 4.1.0 of Ti.Goosh. On previous versions of Android it works without problems. I imagine both for the problem mentioned above. Is version 4.1.0 compatible with Android 8 in some way?

sandrolain commented 6 years ago

Hello I downloaded and created the build of the module with the integration for Oreo channels. But I still do not receive notifications. Should the channel also be specified when sending the server-side notification? I currently send notifications from node servers using node-gcm module, which has no references for the channel. https://github.com/ToothlessGear/node-gcm Thank you

psylus commented 6 years ago

Any plans for a new release to fully support Notifications channels any time soon? Starting August new apps submitted to PlayStore have to target SDK 26, so the module won't be usable any more. Thank you for your work so far