search

caffeinated / menus

:pushpin: Menu generator package for the Laravel framework
https://caffeinatedpackages.com
132 stars 59 forks source link

Invalid <li> syntax #22

Closed Propaganistas closed 9 years ago

Propaganistas commented 9 years ago

Hi

Please take a look at the attached image. Using the asUl() method it seems that an empty tag attribute (both attribute name and value) is being injected into each li element.

I haven't looked at the code, but I expect that this can be solved by simply inserting an if-empty statement when looping over any additionally set attributes.

schermafbeelding 2015-04-23 om 19 38 30

kaidesu commented 9 years ago

Thanks for pointing this out, I'll take a look into it~

kaidesu commented 9 years ago

@Propaganistas If you're able to, pull in the latest dev release through Composer and give it another run to verify that the issue has been fixed on your end!

Propaganistas commented 9 years ago

Fixed indeed. Thanks for the quick follow up!

kaidesu commented 9 years ago

Good to hear~ And no problem :+1: