search

caffeinated / menus

:pushpin: Menu generator package for the Laravel framework
https://caffeinatedpackages.com
132 stars 59 forks source link

Latest laravel breaks package (5.1.24) #68

Closed felorhik closed 8 years ago

felorhik commented 8 years ago 
Declaration of Caffeinated\Menus\Collection::prepend() should be compatible with Illuminate\Support\Collection::prepend($value, $key = NULL)

This shows up when updating to laravel 5.1.24 and loading the library through middleware.

https://github.com/caffeinated/menus/wiki/Quick-Start

is a perfect example of how to recreate this.

felorhik commented 8 years ago

https://github.com/laravel/framework/blame/5.1/src/Illuminate/Support/Collection.php#L550

is where the issue is, looks like a simple fix.

yajra commented 8 years ago

Adding comment to get notified when PR is merged / issue closed. ^_^ Thanks!