search

cafferychen777 / ggpicrust2

Make Picrust2 Output Analysis and Visualization Easier
https://cafferychen777.github.io/ggpicrust2/
Other
92 stars 11 forks source link

Tiny bug in ggpicrust2 function? #3

Closed schuettl closed 1 year ago

schuettl commented 1 year ago

Hi there, thanks a lot for providing this nice package. I think, I found a tiny bug in the ggpicrust2 function:

In line 80 (of ggpicrust2.R) it reads if (select == "NULL"){ which gives the error "Error in if (select == "NULL") { : argument is of length zero" shouldn't it be if (is.null(select)){ ?

cafferychen777 commented 1 year ago

Hello @schuettl ,

Thank you for using ggpicrust2 and for bringing this issue to our attention. You are correct that the line in question should use is.null() instead of "NULL".

This was actually the original implementation of the function, but it was modified for front-end interactivity during its shiny web development. I appreciate your feedback and will make sure to modify the code accordingly. I have already made the modification.

Thank you again for your contribution to improving ggpicrust2!

cafferychen777 commented 1 year ago

Hello @schuettl ,

I have upgrade the version, you can use the following code to get latest version.

# install.packages("devtools")
devtools::install_github("cafferychen777/ggpicrust2")
schuettl commented 1 year ago

Perfect, thanks!