cagataygurturk / image-resizer-service

Serverless image resizing service for AWS
https://serverlessrepo.aws.amazon.com/#/applications/arn:aws:serverlessrepo:us-east-1:526515951862:applications~image-resizer-service
MIT License
101 stars 51 forks source link

Headers aren't passed to cloudfront #7

Open VivienGiraud opened 5 years ago

VivienGiraud commented 5 years ago

Hello, I installed your app using serverless repo on AWS, it works lovely thanks for it! I would like to use cloudfront cache capability but unfortunately it seems that your app does not forward headers. As you can see on these examples : Cache-Control is passed : https://tridea-cdn.s3.eu-west-3.amazonaws.com/favicon.ico Cache-Control isn't passed : https://5xh7ydv0n6.execute-api.eu-west-3.amazonaws.com/production/favicon.ico

Could you please update your code to handle it? Or if the error comes from my side could you help please :)

VivienGiraud commented 5 years ago

@cagataygurturk Any plane to do it?

modgahead commented 4 years ago

@VivienGiraud Hello. I have the same problem. Could you please tell me - how you resolved this?

VivienGiraud commented 4 years ago

@modgahead We just throw it, manually resize to every size required and put it to our CDN...

mathew-adams commented 4 years ago

Hi also looking for this feature. Cache-control would be a welcomed feature to help combat the round-trips to the function if this could be cached completely on the client side.