search

cage1016 / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

fxet_list.h contains some multibyte characters and it results build failure on VC++ on certain locales #123

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
fxet_list.h line 177-179 contains multibyte comments (Actually I cannot read 
them)
and it results in compilation failure if compiled on Visual C++ (at least on 
VS2013) on Japanese locale machine. I think we should remove the comments or 
translate them to English.

Original issue reported on code.google.com by espresso...@gmail.com on 18 Feb 2015 at 8:16

GoogleCodeExporter commented 9 years ago 
Thanks for pointing this out.  We hate non-ascii characters in source code.

Original comment by tsepez@chromium.org on 24 Feb 2015 at 10:17

GoogleCodeExporter commented 9 years ago 
Fixed in 
https://pdfium.googlesource.com/pdfium/+/e796478bac1665628ec1a420afef4c403aa06ca
0

Original comment by tsepez@chromium.org on 24 Feb 2015 at 10:28