search

caged / d3-tip

d3 tooltips
http://labratrevenge.com/d3-tip
MIT License
1.22k stars 349 forks source link

Root element patch #234

Closed tbeckenhauer closed 5 years ago

tbeckenhauer commented 6 years ago

We are running into Issues https://github.com/Caged/d3-tip/issues/190, https://github.com/Caged/d3-tip/issues/191, https://github.com/Caged/d3-tip/issues/208. I am attempting to resolve the issues, with this PR. I see the previous PR https://github.com/Caged/d3-tip/pull/175, but that one is now out of date and has conflicts.

I am not sure what the normal process for building and testing the project, so I am hoping I can get some help walking though those steps.

This does seem solve our use case though.

stale[bot] commented 6 years ago

Hey there! It looks like this issue has been automatically marked as stale because it has not had recent activity. To help the maintainers stay focused, it will be closed if no further activity occurs. Thank you for your contributions.

lucyia commented 6 years ago

Not stale, still requires an attention.

233 and #234 fixing the same issue.

stale[bot] commented 5 years ago

Hey there! It looks like this issue has been automatically marked as stale because it has not had recent activity. To help the maintainers stay focused, it will be closed if no further activity occurs. Thank you for your contributions.