caglardurmus / react-native-insta-story

Story component for React Native
MIT License
178 stars 85 forks source link

Refactor custom components to be render functions #34

Closed IB3N closed 1 year ago

IB3N commented 1 year ago

Reasons for changes

Screenshot 2022-11-22 at 16 39 52

Summary of changes

Important ⚠️

IB3N commented 1 year ago

@caglardurmus please let me know if you would like this not to be a breaking change - I can add the previous props back in and account for them and throw some developer errors if both props are passed, or create something like a CSS cascading order of priority.

Cascading example: oldProp > new renderProp -> defaultPackageComponent

lucasdzuc commented 1 year ago

@IB3N Are these changes already added?

IB3N commented 1 year ago

@lucasdzuc I don't think so, this is the PR to merge them right?