search

cagnulein / qdomyos-zwift

Zwift bridge for smart treadmills and bike/cyclette
https://www.qzfitness.com/
GNU General Public License v3.0
425 stars 116 forks source link

[REQ] Releases for Android #1215

Closed IzzySoft closed 1 year ago

IzzySoft commented 1 year ago

Is your feature request related to a problem? Please describe. While at Google Play your app is listed already with version 2.11.91, the latest version I was able to find here is an APK in a ZIP file named android-1.1.0.zip (at tag 1.1.0) identifying as v1.0 (versionCode 1). Could you please make newer releases available as well (starting with the current one – no need to add all intermediate versions)?

Describe the solution you'd like Ideally, they should be attached as *.apk files directly (not as ZIP). And as each tag can mean a release for a single OS (like there are many for MacOS, some for Windows and only one for Android), the tags could be named accordingly to make it easier to spot the correct ones when collapsed (if e.g. the newest release is for MacOS, that's the only one expanded – all others are collapsed; so one has to expand each of them until one finds the correct one), maybe naming them accordingly (e.g. android-2.11.91 instead of just 2.11.91)?

Describe alternatives you've considered n/a

Additional context For some context, also see here: your app meanwhile is also available in my repo – especially for those without access to Google Play. To provide them with an up-to-date version, my updater must be able to find and download the corresponding APK – which is best achieved as described above.

cagnulein commented 1 year ago

Hah @IzzySoft i didn't get you were mentioning to the QZ app directly, I thought you're talking always about the QZ companion app.

Unfortunately I can put this on your repo because with the google play fee I'm paying the 3rd service that are keeping this whole thing alive.

IzzySoft commented 1 year ago

Unfortunately I can put this on your repo because with the google play fee I'm paying the 3rd service that are keeping this whole thing alive.

I have problems understanding – unless you meant "I can NOT put", that would be very unfortunate indeed. But even then I do not understand what that got to do with the Google Play fee: your app will stay there all the same, and the majority of people will most likely install it from there. Plus the services used by the app will remain the same, regardless where it was installed from, no? I could not get hold of the latest APK yet to see if that would mean a show-stopper due to "too many proprietary components", but that would be something else altogether.

cagnulein commented 1 year ago

I have problems understanding – unless you meant "I can NOT put"

yes sorry, I mean "i can not put" :(

Plus the services used by the app will remain the same, regardless where it was installed from, no?

yes of course, but i'm investing a lot of time on this "hobby" and the google and apple fees are helping me to keep this alive. So i don't want to release the apk for free to the users. Of course the users can build this on their own, but it's my concept of software. You can have it for free if you can build it, otherwise you have to pay the "service".

I hope you will understand my decision.

IzzySoft commented 1 year ago

Well, I don't have to understand it to respect it (and respecting I do of course). What I still don't get is… wait a sec… Ah, those fees. I didn't notice your app is paid on Play (I always assumed "fees" to mean something you had to pay, and not income generated). OK, that makes a difference I can understand. And while there are plenty of examples matching yours (Conversations, DAVx⁵ and others, where the app is paid on Play but free on F-Droid, by choice of their resp. authors), this might of course be different for you. As I wrote, fully respected, accepted and understood.

So what do you suggest to do with the existing listing which currently holds a quite outdated version? Amend the description somehow – or "unlist" again? Is it even still compatible/working with the recent Companion?

cagnulein commented 1 year ago

didn't notice your app is paid on Play (I always assumed "fees" to mean something you had to pay, and not income generated)

yes it's on 5$ (sorry for my english, i'm italian :) )

So what do you suggest to do with the existing listing which currently holds a quite outdated version? Amend the description somehow – or "unlist" again? Is it even still compatible/working with the recent Companion?

I guess we need to unlist this. We can keep the companion there if it's possible

IzzySoft commented 1 year ago

sorry for my english

No prob, we got it figured. Quit-pro-quo: sorry for my not looking correctly, I should have seen the price tag.

I guess we need to unlist this. We can keep the companion there if it's possible

Yes to both – I've just initiated the necessary changes: removed this app, updated the link to it from the companion to point to the Github repo instead, and … was just about to add the NonFreeDep to the companion when I face-palmed: while this app is paid at the Play-by-our-rules-Store, it's still FOSS – so no such flag needed.

Should you one day decide to put an APK on my repo (e.g. from a "lite" version), just give me a ping.

cagnulein commented 1 year ago

Will do, thanks!

cagnulein commented 1 year ago

@IzzySoft I found a solution for this: I created an apk with a time limit that you can unlock joining the patreon membership. Do you think it could work?

IzzySoft commented 1 year ago

For my repo this should work, yes – as long as the source is "available as F/LOSS" (a condition that seems to be met here; sorry for my questioning, I'm processing too many apps to remember all details, so I need to "re-cap").

How would the "unlock" process work then? Will the app itself reach out to validate something against Patreon (or any other 3rd party service)? Then this could simply be mentioned in the app description (together with the trial period's length), I'd add a NonFreeNet flag, and that's it. As long as we're transparent about that, it should be fine then. For F-Droid.org I cannot tell,but I could bring that up in our team discussion if you're interested.

cagnulein commented 1 year ago

The unlock process is a simple web request that reach a server of mine and check if the mail match with the one of my patreon members, if so it unlocks the full version, otherwise the version is limited to 15 minutes.

What do you think?

IzzySoft commented 1 year ago

Fine with me if you're OK with the NonFreeNet mark (folks are used to that one from apps like NewPipe etc so they consider it "transparency" rather than "warning" and will look up the app description for a reason when unsure, so if we communicate it there all should be fine; NonFreeNet would then also cover those "3rd party service(s)"). Let me check what description I had set up the last time, make a suggestion for what we could use – and give your adjustments:

Have you got a Domyos (Decathlon), Echelon, Proform, Flywheel, Yesoul, Toorx treadmill or bike and you want to join to zwift? This app allows you to give a second life to your machine! Also with Peloton you can have auto following workout (it will change resistance for you!) Simply connect your smartphone to the treadmill/bike and zwift will recognize it! Also with Strava Autopload feature!

Compatibility list:

For Nordictrack Trackmills, a matching Companion-App can be found here.

QZ is not affiliated with or endorsed by any subscription service or maker of exercise equipment.

NOTE: This is a free trial version only running for 15 minutes per start. If you want to remove this limitation, you can do so by unlocking the "full version" it via a Patreon membership. Please understand that this is needed to pay the 3rd party service keeping the app working. This part is also the reason for the NonFreeNet anti-feature you are seeing the app marked with.

It's basically the last sentence you might need to adjust. I assume you meant that the app terminates after 15 minutes but can be restarted for another 15 minutes – and not that it just runs for 15 minutes altogether (as that might be quite short to evaluate the app I guess)?

cagnulein commented 1 year ago

no problem with the NonFreeNet flag :) The last sentence is ok for me. yes the app has 15 minute limits and then it auto closes, but you can restart it as many as you want

let me know where I can upload the apk

IzzySoft commented 1 year ago

Attaching the APK to its corresponding release would be fine. Starting with the latest one fully suffices (no need to walk back tags until you can greet Adam & Eve), then keeping it up with future ones. Just give me a ping once it's there, then I set it up and give you a pong back.

Thanks a lot!

cagnulein commented 1 year ago

ok thanks, i will do as soon as a beta user send me a confirmation that it's working

Il giorno sab 18 feb 2023 alle 20:01 Izzy @.***> ha scritto:

Attaching the APK to its corresponding release https://github.com/cagnulein/qdomyos-zwift/releases would be fine. Starting with the latest one fully suffices (no need to walk back tags until you can greet Adam & Eve), then keeping it up with future ones. Just give me a ping once it's there, then I set it up and give you a pong back.

Thanks a lot!

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/1215#issuecomment-1435740731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWF3IQEQUUSLZ3ZAEYDWYEMBDANCNFSM6AAAAAAUIMOK54 . You are receiving this because you modified the open/close state.Message ID: @.***>

-- Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

IzzySoft commented 1 year ago

Looks like the bot doesn't want you to, @cagnulein – it threatens to close the issue as wontfix :scream:

cagnulein commented 1 year ago

yeah sorry i didn't forget about this, i will send you asap

Il giorno dom 5 mar 2023 alle 22:52 Izzy @.***> ha scritto:

Looks like the bot doesn't want you to, @cagnulein https://github.com/cagnulein – it threatens to close the issue as wontfix 😱

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/1215#issuecomment-1455217671, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWFUYAZ36WRTTNYOS3LW2UDIJANCNFSM6AAAAAAUIMOK54 . You are receiving this because you were mentioned.Message ID: @.***>

-- Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

IzzySoft commented 1 year ago

No worries. I mostly wanted to trigger the bot to remove its threat, which worked fine.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

IzzySoft commented 1 year ago

@cagnulein Sorry to annoy you, but the bot wants to be kicked again. Will spam your mailbox each time now, so stay tuned – or take the proper counter-measures :see_no_evil:

cagnulein commented 1 year ago

ah sorry i pinned this now

bb010g commented 1 year ago

I found a solution for this: I created an apk with a time limit that you can unlock joining the patreon membership. Do you think it could work?

Is this Patreon campaign intentionally not linked in the README, or is the linked Buy Me a Coffee campaign its replacement?

cagnulein commented 1 year ago

@bb010g i simply missed to add it :) both are valid!

IzzySoft commented 1 year ago

And there's still no recent release tagged for Android (though PlayStore lists one from 2/2023, the last Android release here is marked from 11/2020), and no APK available? :thinking:

cagnulein commented 1 year ago

yeah sorry i'm still busy with all these stuff. i promise i will do!

IzzySoft commented 1 year ago

OK, no pressure :wink: Just give me a ping when available. Thanks!

cagnulein commented 1 year ago

@IzzySoft sorry for the delay! APK released! Let me know if it's ok

IzzySoft commented 1 year ago

Thanks, yes! But ugh, I didn't expect the APK getting that big (almost 100 MB). Unfortunately, size limit in my repo is 30 MB per app (I was hoping to include it there). But at least it's available for those interested in and not able (or willing) to use Google's walled garden, so thanks a lot!

cagnulein commented 1 year ago

yes 100mb and it is increasing in the next month :)

Il giorno mar 25 lug 2023 alle 23:37 Izzy @.***> ha scritto:

Closed #1215 https://github.com/cagnulein/qdomyos-zwift/issues/1215 as completed.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/1215#event-9916802278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWDO3SOWVA7AOXREE2TXSA4BVANCNFSM6AAAAAAUIMOK54 . You are receiving this because you modified the open/close state.Message ID: @.***>

-- Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

cagnulein commented 1 year ago

any chance to increase the 30mb limit?

IzzySoft commented 1 year ago

Not that much, sorry. I can make exceptions here and there, but not by that number (not only is it more than 3 times the current limit, it is beyond the 32 MB limit of one of the APIs I'm using; I have a work-around for that, but don't ant o xpose it to too many apps).