search

cagnulein / qdomyos-zwift

Zwift bridge for smart treadmills and bike/cyclette
https://www.qzfitness.com/
GNU General Public License v3.0
367 stars 109 forks source link

Bike panel informations have offset of 10 #128

Closed fcrozat closed 3 years ago

fcrozat commented 3 years ago

On Domyos EB900 bike, when connected to qdomyos-zwift is connected, all informations (speed, cadence, calories, etc..) are displayed on bike panel, divided by 10. The correct informations are displayed on qdomyos-zwift.

For instance, cadence is 5 instead of 59. 20210114_064740 Screenshot_20210114-064731

cagnulein commented 3 years ago

Hi @fcrozat could you send me the log about a session, i need something to identify your bike, because I guess it works fine for other domyos bike models, isn't it @kenands ?

Yusuf-Demiryurek commented 3 years ago

Hi @cagnulein, it works fine on my bike :)

fcrozat commented 3 years ago

crash.log

Here are the logs. I've also noticed 3 crashes of qdomyos-zwift which I kept in the log files.

cagnulein commented 3 years ago

Nope. Not this kind of log. I need the debug log that i create in your download folder

Il lun 18 gen 2021, 22:01 Frederic Crozat notifications@github.com ha scritto:

crash.log https://github.com/cagnulein/qdomyos-zwift/files/5832374/crash.log

Here are the logs. I've also noticed 3 crashes of qdomyos-zwift which I kept in the log files.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/128#issuecomment-762468835, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWEKSXKGXCG2F3AMAE3S2SOTDANCNFSM4WFSPZOA .

fcrozat commented 3 years ago

Sorry, I thought you wanted a HCI dump log. debug-Sat Jan 16 23_05_03 2021.log

Now I better understand what is filling my Download folder ;)

cagnulein commented 3 years ago

ok now i understood the issue, @kenands has a changyow bike, @fcrozat has a telink bike. so i will try to multiply by 10 only for telink bikes

fcrozat commented 3 years ago

Please note Decathlon (owner of Domyos) has replaced the panel of EB900 bike in the beginning of 2020 to a new version (called 2020), which I own. I don't know if they switched the provider but at least "officially supporting" applications for this bike (Kinomap or Domyos e-connected ) only work with the "new" version of the console. The "old" version doesn't work properly over Bluetooth and it can be replaced for free by them.

cagnulein commented 3 years ago

ok, it will be avaiable in version >= 2.2.4 i'm closing this one. feel free to reopen it in case of issue @fcrozat

fcrozat commented 3 years ago

I tested latest version with the fix. Speed and calories are fine but cadence is still wrong

cagnulein commented 3 years ago

@fcrozat i checked again the code and the multiplier is on for cadence too. What did you read now on cadence?

fcrozat commented 3 years ago

Screenshot_20210122-065511 20210122_065531

here are the screenshot (taken a few seconds one after the others). I have the debug trace for this particular session, if you need it.

cagnulein commented 3 years ago

@fcrozat i tried now to fix a possible casting issue. We will see it in version 2.2.9

fcrozat commented 3 years ago

Still present with latest beta

cagnulein commented 3 years ago

i guess i understood the issue. on your bike firmware, the cadence, i guess, has 2 bytes for describing the cadence. Which is the max cadence value that you see on the bike display with qdomyos connected? 25.5? and the min? @fcrozat

fcrozat commented 3 years ago

With version 2.3.18, only cadence is wrongly displayed and indeed, panel doesn't go higher than 25 (real cadence being is 52). Lower cadence than 52 are divided by 2 on display, higher are overflowing (display at 001)

cagnulein commented 3 years ago

@fcrozat perfect! So i Will handle it in the next beta version: i was just waiting your confirmation ;)

cagnulein commented 3 years ago

@fcrozat done, it will be avaiable in the next beta

fcrozat commented 3 years ago

Better with 2.3.19, but not there yet. The value is now double of what it should be.

Cadence of 52 is displayed at 104 on the panel

cagnulein commented 3 years ago

Yes because in the last message you told me that was always the half...ok i will remove the *2 so R.

Il mar 16 feb 2021, 22:31 Frederic Crozat notifications@github.com ha scritto:

Better with 2.3.19, but not there yet. The value is now double of what it should be.

Cadence of 52 is displayed at 104 on the panel

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/128#issuecomment-780130247, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWBLC5FXBGXDPI6A5DTS7LP4HANCNFSM4WFSPZOA .

cagnulein commented 3 years ago

it will be avaiable in the next beta @fcrozat

fcrozat commented 3 years ago

Sorry for the slow answer, everything is fine with latest beta 2.4.15.

cagnulein commented 3 years ago

Great! Thanks for the feedback!

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno gio 11 mar 2021 alle ore 08:23 Frederic Crozat < notifications@github.com> ha scritto:

Closed #128 https://github.com/cagnulein/qdomyos-zwift/issues/128.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/128#event-4442404474, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWGDYNMMR2O4MA6YRZTTDBVXFANCNFSM4WFSPZOA .