cagnulein / qdomyos-zwift

Zwift bridge for smart treadmills and bike/cyclette
https://www.qzfitness.com/
GNU General Public License v3.0
376 stars 110 forks source link

Stacked Tread Classes Have Negative Distance #2018

Closed PugMamma closed 8 months ago

PugMamma commented 8 months ago

When playing a Pelton tread classes back to back, I get a negative distance in the second class. If I close down QZ and restart between each class it is fine. QZ recorded the accurate distance, but Peloton is not.

debug-Fri_Jan_19_12_19_02_2024.log Screenshot_20240119-130806 420948123_10162887589748765_7601978955478384653_n 421267213_10162887589738765_343688321598179119_n

cagnulein commented 8 months ago

found an issue @PugMamma i guess it's my fault! i'm fixing this in the 2.16.36 (already patched, I have only to send to google). Thanks for the feedback as always!

PugMamma commented 8 months ago

It was much easier for me to fault Peloton than you. Thanks again for your help.

cagnulein commented 8 months ago

eheheh that's why I always want to check the issues, I'm not bulletproof :) 1:00am here, time to go to bed! Have a nice day!

cagnulein commented 8 months ago

version pushed on the store. it will be available in the next days

Roberto Viola Software engineer and open source enthusias http://robertoviola.cloud

Il giorno sab 20 gen 2024 alle ore 00:41 PugMamma @.***> ha scritto:

It was much easier for me to fault Peloton than you. Thanks again for your help.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2018#issuecomment-1901306742, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWHXQJISKR5C5OKXYGDYPMACXAVCNFSM6AAAAABCCUWY3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBRGMYDMNZUGI . You are receiving this because you were assigned.Message ID: @.***>

PugMamma commented 8 months ago

I saw there was a QZ update today and unsure if it included a fix for this issue. I tried to take 2 classes back to back and had the same problem. The distance QZ sends to Strava is still correct. debug-Mon_Jan_22_17_59_27_2024.log Screenshot_20240122-182343 Peloton DistanceJPG

cagnulein commented 8 months ago

ok so it wasn't the qz issue even before. I understood now what peloton does. When you press the start button on qz, qz clear the odometer starting back from 0 and so it sends to peloton from 0 but peloton, when runs in stack mode, it wants to see a progressive odometer (so they are just stupid because they should manage this event, even or real treadmill).

So there are multiple fixes for this: 1) restarting qz after a class (it could be frustrating, since there is no need to do this) 2) unpair and pair the qz onto pelotn app (this should force peloton to consider qz as a new device). This could be frustrating too since there is no need to do this. 3) i can send not the odometer that you see on the screen but the accumulate of the odometer since the start of qz. This should fix at all the issue and should be transparent for you.

Do you agree that the 3rd option could be the one?

cagnulein commented 8 months ago

modification done. it will be in the 2.16.38 and above

PugMamma commented 8 months ago

Great thanks! Just as a note, Peloton has to pair with the treadmill/QZ during the start of each class.

cagnulein commented 8 months ago

hah didn't know this, but anyway I guess it's the issue (probably they are caching the value). I guess if you close only peloton leaving qz enabled you will not see this issue Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno mar 23 gen 2024 alle ore 17:19 PugMamma @.***> ha scritto:

Great thanks! Just as a note, Peloton has to pair with the treadmill/QZ during the start of each class.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2018#issuecomment-1906416251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWHFSSWB7OHGH6WKIB3YP7PJRAVCNFSM6AAAAABCCUWY3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWGQYTMMRVGE . You are receiving this because you were assigned.Message ID: @.***>

cagnulein commented 8 months ago

version online

PugMamma commented 8 months ago

I did 2 classes back to back and at first it seemed promising. Peloton had the second class start off at 0 (not a negative distance). When there was about 5 minutes left in the class I noticed that Peloton was no longer having the metrics update. It stayed at 0.73 miles and it didn't change my speed or incline. I plan to try back to back classes again over the weekend so unsure if just a fluke or I can just blame Peloton debug-Thu_Jan_25_08_32_46_2024.zip Peloton Hike

cagnulein commented 8 months ago

ok that's definitely an improvement! i checked the log and qz is writing the distance correctly to the peloton app till you press stop the 2nd time. The total distance sent from QZ was 5km (so the sum for the first and the second one). So everything is right from my side. This time it's for sure a peloton bug :) only the distance stopped? or also the other metrics?

PugMamma commented 8 months ago

Everyone on Peloton's side seemed to pause/freeze (distance and incline). I'll continue on testing it out and see if it was a one off issue.

cagnulein commented 8 months ago

Ok, thanks for the update.

Il giorno ven 26 gen 2024 alle 18:24 PugMamma @.***> ha scritto:

Everyone on Peloton's side seemed to pause/freeze (distance and incline). I'll continue on testing it out and see if it was a one off issue.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2018#issuecomment-1912415532, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWDWUVVJQ3ZRLRWVWDDYQPREBAVCNFSM6AAAAABCCUWY3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGQYTKNJTGI . You are receiving this because you were assigned.Message ID: @.***>

PugMamma commented 8 months ago

QZ and Peloton matched up in the second class. Thanks again! 419450357_761794449187608_6450216483118651243_n

cagnulein commented 8 months ago

finally!