cagnulein / qdomyos-zwift

Zwift bridge for smart treadmills and bike/cyclette
https://www.qzfitness.com/
GNU General Public License v3.0
435 stars 118 forks source link

[BUG] Incline not working bor Wahoo Kickr Bike v1 #2224

Closed mtluczek closed 5 months ago

mtluczek commented 8 months ago

Describe the bug Incline control doesn't control the bike which has incline control.

To Reproduce Steps to reproduce the behavior:

  1. Go to QZ Domyos App
  2. Try to +/- incline

Expected behavior Should change the current incline.

Smartphone (please complete the following information):

Append a debug log

Archive.zip

Additional context iFit also doesn't detect the incline capabilities (max/min in its device info settings after successful pairing)

cagnulein commented 8 months ago

Ahh right ok.. So gears change gain and offset, right?

no there are 3 different way to change the final inclination. offset and gain are applied to the resistance coming from ifit. then qz adds the gears.

I forgot iFit can't change inclination and if you added resistance change with inclination it should be perfect.

yes it's what i did

Will you load the new version to the test so I could check it with iFit?

yes i'm sending yout it right now. I hope it doesn't do the crazy horse that it did last time

mtluczek commented 8 months ago

Ahh right ok.. So gears change gain and offset, right?

no there are 3 different way to change the final inclination. offset and gain are applied to the resistance coming from ifit. then qz adds the gears.

what's the formula of the gears addition/application? Can you link to the code?

I forgot iFit can't change inclination and if you added resistance change with inclination it should be perfect.

yes it's what i did

Will you load the new version to the test so I could check it with iFit?

yes i'm sending yout it right now. I hope it doesn't do the crazy horse that it did last time Thanks a lot! I hope also, I've got some meetings now so will probably test tomorrow morning.

cagnulein commented 8 months ago

what's the formula of the gears addition/application? Can you link to the code?

it's just a sum for the gears: inctlination from ifit + the gear value (of course gears can also be negative)

cagnulein commented 8 months ago

@mtluczek any news?

mtluczek commented 8 months ago

Seems it's working allright. However, when I tried changing it with the gear it didn't seem to work or I was using wrong Gear option. Can you tell me where it can be found just to make sure? If it's the same one I'll send the log. The resistance is perfect for me, but it'd be perfect to be able to reduce this offset for my wife. Thanks a lot for all your hard work! Btw. would it be also possible to get the test version for Android? I bought the iphone QZ app, but my android tablet is slow and inconvenient so probably I'd rather use the reversed setup - QZ on the tablet, ifit on iphone airplayed to my laptop.

cagnulein commented 8 months ago

Can you tell me where it can be found just to make sure?

did you enable the gear tile? are you pressing the plus and minus in the gear tile?

If it's the same one I'll send the log.

yes the same

but it'd be perfect to be able to reduce this offset for my wife.

you can create a profile for her in QZ decreasing or the Zwift Resistance Gain or the Zwift Resistance OFsset settings

Btw. would it be also possible to get the test version for Android? I bought the iphone QZ app, but my android tablet is slow and inconvenient so probably I'd rather use the reversed setup - QZ on the tablet, ifit on iphone airplayed to my laptop.

the test version is also already available here https://github.com/cagnulein/qdomyos-zwift/actions/runs/8335472833/artifacts/1337209318

Google is very slow in these days, reviewing the app on the store, even the beta ones. For this reason, in order to check right now if the patch that I did is right, you can use the android build in the link (check at the bottom of the page in about 1 hour). In order to test it you need first to remove the current QZ version on your phone, install the one that you downloaded. This version is a 15 minutes trial (you can restart it as many times as you want) and I can unlock it if you want, send me an email to roberto.viola83@gmail.com mentioning this ticket and that you are on android. Let me know if you have any questions

mtluczek commented 8 months ago

Zrzut ekranu 2024-03-19 o 12 15 44 If that's the one, then when I'm clicking +/- while doing ifit training the resistance doesn't change.

cagnulein commented 8 months ago

got the issue, actually it changed, but after a new different resitance request from ifit. i can add also to change it in realtime if you want.

mtluczek commented 8 months ago

yes, please, it'd be perfect, thanks a lot! So this is the good "Gears" icon/parameter I'm using, right?

cagnulein commented 8 months ago

yes that's right! i will add this, this afternoon

cagnulein commented 8 months ago

already done! https://github.com/cagnulein/qdomyos-zwift/actions/runs/8342151711 it's building for android here if you want to test it. it will be ready in 35 minutes

cagnulein commented 8 months ago

New link https://github.com/cagnulein/qdomyos-zwift/actions/runs/8342851375

mtluczek commented 8 months ago

I've got some temp. problems with installing apk on my android tablet. Can you please also refresh the iOS version for the TestFlight or is it already updated in main app?

cagnulein commented 8 months ago

i have to build the Testflight manually. Which issue do you have with the apk?

mtluczek commented 8 months ago

Hard to tell, it doesn't want to install, trying to install via File app in Adroid.. can't even see the error message

mtluczek commented 8 months ago

Probably some issue with my old android tablet

cagnulein commented 8 months ago

you have to uninstall first the app from the play store. which android version do you have there?

mtluczek commented 8 months ago

I haven't got any QZ app from play store, I tested QZ on iphone before only, this old android tablet just doesn't want to install the apk file even though I allowed the external apps from unknown sources. What android version does the app require? Maybe I need to update the OS.

cagnulein commented 8 months ago

at least android 6 anyway in case i will send you the testflight version tomorrow

mtluczek commented 8 months ago

Thanks a lot!

cagnulein commented 8 months ago

ios version sent

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno mar 19 mar 2024 alle 17:47 mtluczek @.***> ha scritto:

Thanks a lot!

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2224#issuecomment-2007667157, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWER2O2V6MI3RKF4KELYZBT3BAVCNFSM6AAAAABEWIMOKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXGY3DOMJVG4 . You are receiving this because you were assigned.Message ID: @.***>

cagnulein commented 8 months ago

@mtluczek any news?

mtluczek commented 8 months ago

Hi, all ok, just wondering if it'd be possible to change incline proportional to resistance if I can see the changing incline in UI in sensible way anyways, so was just wondering if this could be added as well. What do you think?

cagnulein commented 8 months ago

it's already did in this way. Inclination is changing proportionally to the resistance. You can change the linearity of this with the zwift resistance gain and offset settings

mtluczek commented 8 months ago

Hmm.. the bike didn't incline or decline in iFit, only resistance changed, while it worked when changing inclination manually. I will recheck again and send the log.

cagnulein commented 8 months ago

i guess i'm missing something in the translation. Let's recap:

what's wrong in these? the last point? if so, do you see the target incline value correctly?

stale[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cagnulein commented 7 months ago

@mtluczek any news?

mtluczek commented 7 months ago

Hi Roberto,

I will be re-checking till the end of this week and will update, sorry!

Best wishes, Marek

śr., 17 kwi 2024 o 15:12 Roberto Viola @.***> napisał(a):

@mtluczek https://github.com/mtluczek any news?

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2224#issuecomment-2061231735, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATKLVVOFWM7VNMWKPQMGRS3Y5ZYMRAVCNFSM6AAAAABEWIMOKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGIZTCNZTGU . You are receiving this because you were mentioned.Message ID: @.***>

stale[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cagnulein commented 6 months ago

@mtluczek any news?

mtluczek commented 6 months ago

I'm sorry for not replying, didn't have time to check it and has some problems with my Android tablet.

Will recheck this weekend for sure and let you know.

Best wishes, Marek

pt., 10 maj 2024 o 14:09 Roberto Viola @.***> napisał(a):

@mtluczek https://github.com/mtluczek any news?

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2224#issuecomment-2104497852, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATKLVVKJ5LQY2QBEEQE5XRLZBS2JBAVCNFSM6AAAAABEWIMOKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUGQ4TOOBVGI . You are receiving this because you were mentioned.Message ID: @.***>

stale[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cagnulein commented 6 months ago

Let's wait :)

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cagnulein commented 5 months ago

@mtluczek any news?

mtluczek commented 5 months ago

Yes, tested it and seems the incline works great when I test it with the app, but it's not working in iFit - only resistance change works in iFit.

cagnulein commented 5 months ago

Yes I didn't handle the ifit inclination request yet.

If you have a debug log from qz with the inclination request from ifit I can handle that too