[REQ] Replace use of no action values with C++17 std::optional

cagnulein / qdomyos-zwift

Zwift bridge for smart treadmills and bike/cyclette

https://www.qzfitness.com/

GNU General Public License v3.0

337 stars 103 forks source link

[REQ] Replace use of no action values with C++17 std::optional #2269

Open drmason789 opened 1 month ago

drmason789 commented 1 month ago

and use resistanceRequest.has_value() and resistanceRequest.reset() instead of having a "no action constant". If you are agreeable, I will do this for the resistance, inclination and power requests, in a different PR.

yes sure! thanks!

_Originally posted by @cagnulein in https://github.com/cagnulein/qdomyos-zwift/pull/2174#discussion_r1547318058_

drmason789 commented 1 month ago

I've volunteered to do this.

For each varname that's optional

replace comparisons with the "no value" value with varname.has_value()
replace comparisons with other values with varname.value()
use varname.value_or(...) where possible
replace assignment of the "no value" value with varname.reset()

stale[bot] commented 3 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.