search

cagnulein / qdomyos-zwift

Zwift bridge for smart treadmills and bike/cyclette
https://www.qzfitness.com/
GNU General Public License v3.0
337 stars 103 forks source link

[REQ] Introduce typedefs for inclination, power, heart rate, cadence, peloton resistance #2270

Open drmason789 opened 1 month ago

drmason789 commented 1 month ago

@cagnulein Remember the resistance_t change? Would you be agreeable to me adding cadence_t, heartRate_t, power_t, pelotonResistance_t, inclination_t alongside it and propagating throughout the codebase, in a different PR?

@drmason789 yes sure!

Originally posted by @cagnulein in https://github.com/cagnulein/qdomyos-zwift/issues/2174#issuecomment-2031354165

drmason789 commented 1 month ago

I've volunteered to do this.

drmason789 commented 1 month ago

typedef int8_t peloton_t; typedef int16_t power_t; typedef int16_t cadence_t; typedef double inclination_t;

Using signed ints initially even though negative values don't make sense, for use with the "no value" pattern pre-#2269

stale[bot] commented 3 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.