cagnulein / qdomyos-zwift

Zwift bridge for smart treadmills and bike/cyclette
https://www.qzfitness.com/
GNU General Public License v3.0
366 stars 109 forks source link

[BUG] Virtual shifting lags #2470

Closed jontnswift closed 3 weeks ago

jontnswift commented 1 month ago

Describe the bug Resistance does not change quickly after shifting, sometimes resulting in overshifting

To Reproduce Steps to reproduce the behavior: upshift and increase power resistance does not increase so I shifted again, several times suddenly resistance catches up causing my cadence to grind down downshifting takes several seconds to adjust as well

Expected behavior Shifting should result in immediate or nearly immediate changes to resistance

Screenshots N/A

Desktop (please complete the following information):

Smartphone (please complete the following information):

Append a debug log

Follow this guide https://github.com/cagnulein/qdomyos-zwift/wiki/How-do-i-get-the-debug-log-in-case-something-doesn't-work%3F

Additional context I tried both race mode and a direct ethernet connection to the phone. Neither helped.

debug-Mon_Jul_22_23_00_29_2024.zip

cagnulein commented 1 month ago

thanks i will check it later today

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno mar 23 lug 2024 alle 05:48 jontnswift @.***> ha scritto:

Assigned #2470 https://github.com/cagnulein/qdomyos-zwift/issues/2470 to @cagnulein https://github.com/cagnulein.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2470#event-13609325021, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWGM25JDXWRPSGRQ5ATZNXHBRAVCNFSM6AAAAABLJRVOIOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGYYDSMZSGUYDEMI . You are receiving this because you were assigned.Message ID: @.***>

cagnulein commented 1 month ago

ok same of this https://github.com/cagnulein/qdomyos-zwift/issues/2153 i'm applying the same patch I will send you a new one today @jontnswift !

cagnulein commented 1 month ago

done @jontnswift https://github.com/cagnulein/qdomyos-zwift/actions/runs/10055228682 Google is very slow in these days, reviewing the app on the store, even the beta ones. For this reason, in order to check right now if the patch that I did is right, you can use the android build in the link (check at the bottom of the page in about 1 hour). In order to test it you need first to remove the current QZ version on your phone, install the one that you downloaded. This version is a 15 minutes trial (you can restart it as many times as you want) and I can unlock it if you want, send me an email to roberto.viola83@gmail.com mentioning this ticket and that you are on android. Let me know if you have any questions

jontnswift commented 1 month ago

I have the version from github installed and will test it this evening

cagnulein commented 1 month ago

perfect! let me know!

jontnswift commented 1 month ago

Attaching 2 new logs. The new build seems better. Race mode with the new build seems worse. The lag is intermittent, not all the time, and it seems to get worse when I shift several gears quickly.

jontnswift commented 1 month ago

QZdebuglogs.zip

cagnulein commented 1 month ago

ok i guess i found the reason

https://github.com/cagnulein/qdomyos-zwift/actions/runs/10071021979

can you try this? thanks

jontnswift commented 1 month ago

I will take try it tomorrow after work. Thanks again.

jontnswift commented 1 month ago

That made a huge difference! The delay is now approximately the same as the change in resistance on my trainer when the incline changes on zwift (~1 second). I can upload a new log if you'd like, but I think we are good at this point.

cagnulein commented 1 month ago

Amazing! In case we can also lower the 200ms if you want, but this impact also on the battery of your qz device

stale[bot] commented 4 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.