cagnulein / qdomyos-zwift

Zwift bridge for smart treadmills and bike/cyclette
https://www.qzfitness.com/
GNU General Public License v3.0
367 stars 109 forks source link

[BUG] Pro-form Carbon E7 not connecting #2515

Open sanicki opened 4 weeks ago

sanicki commented 4 weeks ago

Describe the bug QZ app on Android phone appears to connect to the QZ Companion app installed on a Pro-form Carbon E7 elliptical, but tiles show no readings and do not control the elliptical.

To Reproduce Steps to reproduce the behavior:

  1. Complete steps on https://github.com/cagnulein/QZCompanionNordictrackTreadmill, using QZ Installation Method 2.
  2. In QZ Companion app, select "Other" as equipment type

Expected behavior Expected QZ tiles to display speed, incline, resistance, etc. of elliptical and to be able to control incline and resistance from QZ app.

Screenshots If applicable, add screenshots to help explain your problem. Screenshot_20240815_125610 Screenshot_20240815_125538 20240815_125412 20240815_125441

Desktop (please complete the following information):

Smartphone (please complete the following information):

Append a debug log debug-Thu_Aug_15_12_55_04_2024.log

Follow this guide https://github.com/cagnulein/qdomyos-zwift/wiki/How-do-i-get-the-debug-log-in-case-something-doesn't-work%3F

Additional context Add any other context about the problem here.

cagnulein commented 4 weeks ago

there is a setup error: don't set the ip in the proform ip setting: remove it completely from there and press ok. set it instead on the 2950 ip setting and press ok and restart qz

if it still doesn't work send me a fresh debug log thanks

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno gio 15 ago 2024 alle 20:49 Scott Sanicki @.***> ha scritto:

Assigned #2515 https://github.com/cagnulein/qdomyos-zwift/issues/2515 to @cagnulein https://github.com/cagnulein.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2515#event-13900855483, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWAYENXFMNHHOCJO76LZRTZ3LAVCNFSM6AAAAABMSWZLF2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHEYDAOBVGU2DQMY . You are receiving this because you were assigned.Message ID: @.***>

sanicki commented 4 weeks ago

Reinstalled QZ Companion app using recommended QZ Installation Method 1 (from Windows 11.)

Moved IP as instructed and restarted QZ app.

Still nothing.

debug-Thu_Aug_15_13_41_03_2024.log

cagnulein commented 4 weeks ago

i still see the ip in the other setting

Thu Aug 15 13:41:04 2024 1723750864087 Debug: ../src/main.cpp int main(int, char **) "proformtreadmillip" QVariant(QString, "192.168.1.72")

you have to complete remove it (no spaces or any character) and press ok and restart qz

let me know

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno gio 15 ago 2024 alle 21:45 Scott Sanicki @.***> ha scritto:

Reinstalled QZ Companion app using QZ Installation Method 1 (from Windows 11.)

Moved IP as instructed and restarted QZ app.

Still nothing.

debug-Thu_Aug_15_13_41_03_2024.log https://github.com/user-attachments/files/16629626/debug-Thu_Aug_15_13_41_03_2024.log

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2515#issuecomment-2292069136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWDUH66ZHJNND4PRXDDZRUAMVAVCNFSM6AAAAABMSWZLF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSGA3DSMJTGY . You are receiving this because you were mentioned.Message ID: @.***>

cagnulein commented 4 weeks ago

i'm going to bed soon, i will be back in 10 hours

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno gio 15 ago 2024 alle 21:47 cagnulein @.***> ha scritto:

i still see the ip in the other setting

Thu Aug 15 13:41:04 2024 1723750864087 Debug: ../src/main.cpp int main(int, char **) "proformtreadmillip" QVariant(QString, "192.168.1.72")

you have to complete remove it (no spaces or any character) and press ok and restart qz

let me know

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno gio 15 ago 2024 alle 21:45 Scott Sanicki < @.***> ha scritto:

Reinstalled QZ Companion app using QZ Installation Method 1 (from Windows 11.)

Moved IP as instructed and restarted QZ app.

Still nothing.

debug-Thu_Aug_15_13_41_03_2024.log https://github.com/user-attachments/files/16629626/debug-Thu_Aug_15_13_41_03_2024.log

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2515#issuecomment-2292069136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWDUH66ZHJNND4PRXDDZRUAMVAVCNFSM6AAAAABMSWZLF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSGA3DSMJTGY . You are receiving this because you were mentioned.Message ID: @.***>

sanicki commented 4 weeks ago

IP removed (my oversight -- missed the need for ok per line item.)

Elliptical incline now seen. Incline not adjustable in app. Speed not registering.

debug-Thu_Aug_15_13_46_50_2024.log

cagnulein commented 4 weeks ago

perfect! for the speed no problem, we can use the ratio between rpm and distance to calculate it. i just need two different speed/cadence couple to calculate it

for the inclination control i need a adb screenshot that you can take using the adb screenshot batch file in the zip file

let me know!

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno gio 15 ago 2024 alle 21:54 Scott Sanicki @.***> ha scritto:

IP removed (my oversight -- missed the need for ok per line item.)

Elliptical incline now seen. Incline not adjustable in app. Speed not registering.

debug-Thu_Aug_15_13_46_50_2024.log https://github.com/user-attachments/files/16629702/debug-Thu_Aug_15_13_46_50_2024.log

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2515#issuecomment-2292085059, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWDDU7D3PMJ4U2MX7HDZRUBPTAVCNFSM6AAAAABMSWZLF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSGA4DKMBVHE . You are receiving this because you were mentioned.Message ID: @.***>

sanicki commented 4 weeks ago

i just need two different speed/cadence couple to calculate it

Apologies. It is only the Inclination reading that is displaying. No other tile displays any information.

Screenshot_20240815_142902

for the inclination control i need a adb screenshot that you can take using the adb screenshot batch file in the zip file

What screen do you need? When I used that bat I only got:

Thu08-15-2024@14-24-51 19

cagnulein commented 4 weeks ago

the adb screenshot is perfect but you need to enable the sliders in the ifit settings to change the inclination in that screen and so redo a screenshot. let me know!

cagnulein commented 4 weeks ago

@sanicki i just pushed a new version handling all the metrics from this elliptical (inclination pending due to sliders missing in the screenshot). send me an email to roberto.viola83 at gmail.com indicating this ticket and if you are on android or iOS. Thanks

sanicki commented 3 weeks ago

Fri08-16-2024@8-00-36 11

Better? Sending email now. Thanks!

cagnulein commented 3 weeks ago

yes better thanks! i will add it in the next days! for instead the qz version , Google is very slow in these days, reviewing the app on the store, even the beta ones. For this reason, in order to check right now if the patch that I did is right, you can use the android build in the link (check at the bottom of the page in about 1 hour). In order to test it you need first to remove the current QZ version on your phone, install the one that you downloaded. This version is a 15 minutes trial (you can restart it as many times as you want) and I can unlock it if you want, send me an email to roberto.viola83@gmail.com mentioning this ticket and that you are on android. Let me know if you have any questions

https://github.com/cagnulein/qdomyos-zwift/actions/runs/10414985767/artifacts/1818779341

sanicki commented 3 weeks ago

Readings seem to be working!

Screenshot_20240816_083551

Adjustments attempted in the phone app do not appear to work, but may be because the companion app is expanding the notification window?

Fri08-16-2024@8-35-43 17

(Also the companion app looks to have changed the workout screen layout, but I'm not sure if that's expected.)

cagnulein commented 3 weeks ago

yes i need to add your specific carbon device to the companion, i will try to do later today!

cagnulein commented 3 weeks ago

remember then you have to stay in the manual window with the slider bar to have it working correctly

sanicki commented 3 weeks ago

remember then you have to stay in the manual window with the slider bar to have it working correctly

The screenshot I added above shows the layout iFit switches to when I start the phone app while iFit is in manual workout with the sliders present.

cagnulein commented 3 weeks ago

yeah i said so because i saw this screenshot image i would like to be sure that you got that you have to stay in the manual workout when you will receive the new companion app

sanicki commented 3 weeks ago

Understood. I think that the current companion app switched screens due to the same touch misalignment that is lowering the notification window.

Oh, also FYI in the beta phone app: Since I need to enter the companion app IP I had to skip the new setup wizard, but skipping it seems to cause the wizard to launch again the next time the app is started.

cagnulein commented 3 weeks ago

hah yes i have to fix this, thanks for the reminder!

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno ven 16 ago 2024 alle 17:24 Scott Sanicki @.***> ha scritto:

Understood. I think that the current companion app switched screens due to the same touch misalignment that is lowering the notification window.

Oh, also FYI in the beta phone app: Since I need to enter the companion app IP I had to skip the new setup wizard, but skipping it seems to cause the wizard to launch again the next time the app is started.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2515#issuecomment-2293711688, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWGUPMZ4U7PTGTUCNSDZRYKUDAVCNFSM6AAAAABMSWZLF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJTG4YTCNRYHA . You are receiving this because you were mentioned.Message ID: @.***>

cagnulein commented 3 weeks ago

@sanicki done https://github.com/cagnulein/QZCompanionNordictrackTreadmill/releases/download/3.4.7/QZCompanionNordictrackTreadmill.apk

select the new e7 elliptical device in the companion. let me know!

sanicki commented 3 weeks ago

The phone app is now reading everything correctly, except Heart Rate (from the built-in HR monitor) and Fan Speed. Neither of those are particularly important to me, because I'll be relying on my watch for heart rate and don't need to monitor or control the fan from my phone.

Equipment adjustments attempted in the phone app still do not appear to do anything. I also tried using a GPX, but I wasn't able to select one in the beta phone app. (It had worked in the prod version.)

cagnulein commented 3 weeks ago

The phone app is now reading everything correctly, except Heart Rate (from the built-in HR monitor) and Fan Speed. Neither of those are particularly important to me, because I'll be relying on my watch for heart rate and don't need to monitor or control the fan from my phone.

Yeah unfortunately it seems to doesn't log them, so I can't show them .

Equipment adjustments attempted in the phone app still do not appear to do anything.

do you see a random touch as you saw before? or nothing? you have to use the inclination tile to change it

I also tried using a GPX, but I wasn't able to select one in the beta phone app. (It had worked in the prod version.)

what do you mean? what do you see?

sanicki commented 3 weeks ago

Sorry for the delay. I was AFK yesterday.

do you see a random touch as you saw before? or nothing? you have to use the inclination tile to change it

Nothing. No change to elliptical settings when I'm pressing the -/+ in Inclination or Resistance in the phone app.

what do you mean? what do you see?

I don't see file names, only partial folder names in the file picker. Selecting "Other folders" allows me to view the contents of other folders but does not let me pick the correct folder (worked in non-beta) or a GPX file.

Screenshot_20240818_101647

cagnulein commented 3 weeks ago

But when you selected other on the companion are you still see a wrong touch event or not anymore?

Are you on android 14? Delete the /documents/qz folder and restart qz and then browse there to /documents/qz

sanicki commented 3 weeks ago

When I select "Other" on the Companion app I no longer see a wrong touch event. Pressing the -/+ in Inclination or Resistance in the phone app do not work when other is selected either.

When I exit the phone app the service appears to automatically restart, which causes touch events on the elliptical when it is no longer in workout mode. This causes the elliptical to lose Privileged mode. I don't believe this is the cause of the -/+ issue but figure I should mention it. I have to force close the app to stop the service from restarting.

I deleted that folder and now see the stock GPX files. So I was able to confirm that GPX maps also do not affect the workout Incline or Resistance.

cagnulein commented 3 weeks ago

I'm missing something : i thought you were able to see a wrong touch event when you press the inclination tile on qz: how?

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno dom 18 ago 2024 alle 23:47 Scott Sanicki @.***> ha scritto:

When I select "Other" on the Companion app I no longer see a wrong touch event. Pressing the -/+ in Inclination or Resistance in the phone app do not work when other is selected either.

When I exit the phone app the service appears to automatically restart, which causes touch events on the elliptical when it is no longer in workout mode. This causes the elliptical to lose Privileged mode. I don't believe this is the cause of the -/+ issue but figure I should mention it. I have to force close the app to stop the service from restarting.

I deleted that folder and now see the stock GPX files. So I was able to confirm that GPX maps also do not affect the workout Incline or Resistance.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2515#issuecomment-2295406321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWGP6KRZKYPPDWQCVVDZSEI5XAVCNFSM6AAAAABMSWZLF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGQYDMMZSGE . You are receiving this because you were mentioned.Message ID: @.***>

sanicki commented 3 weeks ago

I'm missing something : i thought you were able to see a wrong touch event when you press the inclination tile on qz: how?

No, I have not seen a wrong touch event since you provided the test companion app which includes the E7.

(The confusion may have been my choice of words. When I said the phone app was "reading" the elliptical data I maybe should have said "displaying"? What I meant was that changes that I make on the elliptical are reflected in the phone app. Changes attempted in the phone app have no effect on the elliptical. Does that make more sense?)

cagnulein commented 3 weeks ago

that's strange because if you set the "other" it should behaves like the previous one. are you able to reinstall the previous just to confirm this? we need a stable starting point Thanks

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno lun 19 ago 2024 alle 14:16 Scott Sanicki @.***> ha scritto:

I'm missing something : i thought you were able to see a wrong touch event when you press the inclination tile on qz: how?

No, I have not seen a wrong touch event since you provided the test companion app which includes the E7.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2515#issuecomment-2296434428, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWAW56BRICNXJDUDKELZSHO23AVCNFSM6AAAAABMSWZLF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJWGQZTINBSHA . You are receiving this because you were mentioned.Message ID: @.***>

sanicki commented 3 weeks ago

Can you please send me links to the versions you'd like me to revert to for:

  1. The phone app (I have the 15 minute one from earlier in this thread currently installed)
  2. The companion app (when I download from https://tinyurl.com/qz-companion it still lists the E7)
  3. The watch app (I have the beta for Samsung currently installed)

I can't seem to locate the companion APK prior to the addition of my elliptical.

cagnulein commented 3 weeks ago

The one that I would like to revert is the companion only for now You can find all of them here https://github.com/cagnulein/QZCompanionNordictrackTreadmill/releases the previous one is https://github.com/cagnulein/QZCompanionNordictrackTreadmill/releases/download/3.4.6/QZCompanionNordictrackTreadmill.apk

Thanks

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno lun 19 ago 2024 alle 19:51 Scott Sanicki @.***> ha scritto:

Can you please send me links to the versions you'd like me to revert to for:

  1. The phone app (I have the 15 minute one from earlier in this thread currently installed)
  2. The companion app (when I download from https://tinyurl.com/qz-companion it still lists the E7)
  3. The watch app (I have the beta for Samsung currently installed)

I can't seem to locate the companion APK prior to the addition of my elliptical.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2515#issuecomment-2297116193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWDZTJGR56RPXRKXPJTZSIWDRAVCNFSM6AAAAABMSWZLF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGEYTMMJZGM . You are receiving this because you were mentioned.Message ID: @.***>

sanicki commented 3 weeks ago

👍 3.4.6 companion installed. No wrong touches with Other, though.

Maybe because of different phone app?

cagnulein commented 3 weeks ago

Ok so yes it could be the phone app. So try this: reinstall back the latest companion and put back the ip on the 2950 treadmill ip blanking the elliptical one and check. if you see them means that i did something wrong in the elliptical side, thanks

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno lun 19 ago 2024 alle 20:10 Scott Sanicki @.***> ha scritto:

👍 3.4.6 companion installed. No wrong touches with Other, though.

Maybe because of different phone app?

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2515#issuecomment-2297149092, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWBVZ4G65CJQJA55JPDZSIYLFAVCNFSM6AAAAABMSWZLF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGE2DSMBZGI . You are receiving this because you were mentioned.Message ID: @.***>

sanicki commented 3 weeks ago

It looks like the Google Play store version has been updated. I checked https://github.com/cagnulein/qdomyos-zwift/releases/ but it only has the July 2023 and nightly trial apks. Where can I get the previous release?

I don't know if this is useful but I turned on "Show taps" in Developer Mode on the elliptical and nothing displays when I tap the -/+ for Inclination or Resistance from the current phone app.

cagnulein commented 3 weeks ago

just use this for qz on the phone https://github.com/cagnulein/qdomyos-zwift/actions/runs/10414985767/artifacts/1818779341

I don't know if this is useful but I turned on "Show taps" in Developer Mode on the elliptical and nothing displays when I tap the -/+ for Inclination or Resistance from the current phone app.

yes it will be useful, leave it enabled for now

sanicki commented 3 weeks ago

Progress!

I realized that even though I had started the Companion app and selected Other, I needed to open it again in order for the ADB debugging request.

Once I did that, the Companion app began showing the wrong touches.

So I reinstalled the Companion app with the E7 and after manually starting the app twice (first to select E7, second to permit ADB) I was able to use -/+ to change Inclination.

But once I did, the workout zoomed in to the track-only and overlayed a screen with an option to full-screen.

cagnulein commented 3 weeks ago

i don't get the last phrase: what do you mean? you can't stay in the manual workout or the companion is sending faking touch that changes the screen?

sanicki commented 3 weeks ago

It looks like this:

Mon08-19-2024@12-59-51 13

Until I tap + on the Inclination tile in the phone app, at which time the elliptical inclination changes but the screen displays:

Mon08-19-2024@12-43-57 21

Then cycles back and forth between that and this every second or two:

Mon08-19-2024@12-45-12 18

Edit: On subsequent attempts it immediately starts cycling through those two screens, without the Inclination tap on the phone.

cagnulein commented 3 weeks ago

ok so it means that it's a coordinates issue. are you able to collect a adb logcat while you are doing this experiment?

sanicki commented 3 weeks ago

Not sure if this worked, but...

logcat.txt

cagnulein commented 3 weeks ago

yes it worked thanks. did you change the resistance tile on qz on this right? change instead the inclination, it should be fine then

sanicki commented 3 weeks ago

It was definitely Inclination that I was able to change with the tile, but I may have tried both. (If Resistance changed I may not have noticed.)

cagnulein commented 3 weeks ago

i'm going to bed now, if you can collect a fresh adb log with only the inclination i will check it. anyway we are very near! have a nice evening!

cagnulein commented 2 weeks ago

hi @sanicki any news?

stale[bot] commented 2 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sanicki commented 14 hours ago

Sorry for the extremely long delay. Here is a new logcat where I unsuccessfully attempted to control inclination and resistance from the phone app.

logcat.txt

cagnulein commented 3 hours ago

i got the issue, QZ (on the version that you are trying now and with the configuration that you have) is sending resistance instead of inclination. so in order to understand the setup issue i need also a debug log from qz, https://github.com/cagnulein/qdomyos-zwift/wiki/How-do-i-get-the-debug-log-in-case-something-doesn't-work%3F

let me know! we are very near!