cagnulein / qdomyos-zwift

Zwift bridge for smart treadmills and bike/cyclette
https://www.qzfitness.com/
GNU General Public License v3.0
431 stars 117 forks source link

[BUG] Pause button on qz won't reset the speed tile #2781

Closed lorenzogavanna closed 1 week ago

lorenzogavanna commented 1 week ago

Describe the bug A clear and concise description of what the bug is.

Steps to reproduce the behavior:

  1. Press start btn
  2. set a decent speed (in order to make it not too long)
  3. Press pause btn
  4. speed tile won't go to 0
  5. odometer will keep goin

The treadmill stops and stays in pause mode properly. Everything in the fit file seems to be correct. The odometer should pause since nothing is running and the speed tile should go to 0.

OS: G7 thinkQ - Android 10 Mobvoi Home Treadmill Plus QZ app 2.18.1 debug log attached.

debug-Thu_Nov_14_15_55_20_2024.log

cagnulein commented 1 week ago

@lorenzogavanna done! https://github.com/cagnulein/qdomyos-zwift/actions/runs/11840525088 Google is very slow in these days, reviewing the app on the store, even the beta ones. For this reason, in order to check right now if the patch that I did is right, you can use the android build in the link (check at the bottom of the page in about 1 hour). In order to test it you need first to remove the current QZ version on your phone, install the one that you downloaded. This version is a 15 minutes trial (you can restart it as many times as you want) and I can unlock it if you want, send me an email to roberto.viola83@gmail.com mentioning this ticket and that you are on android. Let me know if you have any questions

cagnulein commented 1 week ago

i just don't update the distance, i didn't touch the speed value

lorenzogavanna commented 1 week ago

Yes, now the odometer is not going, the speed stays there. Perfect! The only thing I noticed is that when you resume from the pause state the speed won't be resumed as it's in the tile (as it should be), but it starts from the minimum, i think it's set from the treadmill. The treadmill is properly in pause state. Probably it was the same behavior even before, but I didn't notice that. Let me know if you need more info.

cagnulein commented 1 week ago

yes that's for safety reason. would you like to resume to the latest instead?

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno gio 14 nov 2024 alle 17:33 lorenzogavanna < @.***> ha scritto:

Yes, now the odometer is not going, the speed stays there. Perfect! The only thing I noticed is that when you resume from the pause state the speed won't be resumed as it's in the tile (as it should be), but it starts from the minimum, i think it's set from the treadmill. The treadmill is properly in pause state. Probably it was the same behavior even before, but I didn't notice that. Let me know if you need more info.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/2781#issuecomment-2476886164, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWGRUMZRQQYPLGE4T3L2ATGGXAVCNFSM6AAAAABRZFERRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWHA4DMMJWGQ . You are receiving this because you were assigned.Message ID: @.***>

lorenzogavanna commented 1 week ago

Oh I see, didn't think about that!! Stick to your settings, safety first!! eheh
I close this bug report since everthing now works properly. Thank you again Roberto!