search

cagnulein / qdomyos-zwift

Zwift bridge for smart treadmills and bike/cyclette
https://www.qzfitness.com/
GNU General Public License v3.0
343 stars 104 forks source link

Suddenly broken after settings change #769

Closed jonathancolledge closed 2 years ago

jonathancolledge commented 2 years ago

I thought all I changed was pause on start, but my finger must have changed another setting too.

Anyway, QZ won't load - help please! I have attached a log. I removed it all and rebuilt, but still no luck. debug-Tue_Apr_12_06_03_14_2022.log

cagnulein commented 2 years ago

@jonathancolledge eheheh don't worry, it's important to understand your issue :) But i still don't get it if you're following my advice here https://github.com/cagnulein/qdomyos-zwift/issues/422#issuecomment-895196700 the deviceConnected function is called at the end of the homeform constructor? That's why i need to see a git diff: in order to see if you do the right mod. If you want I can mantain a branch for this, or, maybe better, i can fix the issue :)

jonathancolledge commented 2 years ago

Oh dear I'm not following the advice on here #422 (comment) as the make fails. I just tried it again and it didn't work. When that first happened, I had then seen another post about removing the #ifdef TEST and #endif and that solved it for a while.

jonathancolledge commented 2 years ago

Oh dear I'm not following the advice on here #422 (comment) as the make fails. I just tried it again and it didn't work. When that first happened, I had then seen another post about removing the #ifdef TEST and #endif and that solved it for a while.

cagnulein commented 2 years ago

didn't work means that doesn't build or that the tiles are not coming up? please post a git diff :)

jonathancolledge commented 2 years ago

Yeah I'll try a git diff now. I've figured out what I was doing wrong - I was trying the git diff on the working one and I don't think it likes that.

By didn't work, the make failed and it didn't build.

I've found the post regarding the modification here: https://github.com/cagnulein/qdomyos-zwift/issues/495#issuecomment-1013675578

cagnulein commented 2 years ago

@jonathancolledge if it will be easy for you i can maintain a branch with this change. what do you think?

jonathancolledge commented 2 years ago 
ubuntu@ubuntu:~$ cd qdomyos-zwift
ubuntu@ubuntu:~/qdomyos-zwift$ git diff
diff --git a/src/homeform.cpp b/src/homeform.cpp
index 0a4cd675..e103926b 100644
--- a/src/homeform.cpp
+++ b/src/homeform.cpp
@@ -334,10 +334,8 @@ homeform::homeform(QQmlApplicationEngine *engine, bluetooth *bl) {
     connect(pelotonHandler, &peloton::loginState, this, &homeform::pelotonLoginState);
     connect(pelotonHandler, &peloton::pzpLoginState, this, &homeform::pzpLoginState);

-#ifdef TEST
     QBluetoothDeviceInfo b;
     deviceConnected(b);
-#endif
 }

 void homeform::setActivityDescription(QString desc) { activityDescription = desc; }
cagnulein commented 2 years ago

@jonathancolledge seems perfect. which make issue do you have now?

jonathancolledge commented 2 years ago

@jonathancolledge if it will be easy for you i can maintain a branch with this change. what do you think?

Is that what the raspberry branch is? If it more effort for you, I can keep doing this: Once I change directory to src, I do sudo gedit homeform.cpp and take out those lines. That's the git diff above. I promise it was giving a segmentation fault before, but it works now...

cagnulein commented 2 years ago

no effort at all, it's very easy :)

jonathancolledge commented 2 years ago

@jonathancolledge seems perfect. which make issue do you have now?

No issue now! I don't know what happened. My original git diff of the homeform.cpp shows I made the same changes as that last one. I checked multiple times and it would give the same fault. Oh well, sorry.

jonathancolledge commented 2 years ago

no effort at all, it's very easy :)

Ok, thank you very much

cagnulein commented 2 years ago

No issue now! I don't know what happened. My original git diff of the homeform.cpp shows I made the same changes as that last one. I checked multiple times and it would give the same fault. Oh well, sorry.

probably it's something that we haven't understood yet

jonathancolledge commented 2 years ago

probably it's something that we haven't understood yet

Either way, thank you for your patience. Have a great weekend!

jonathancolledge commented 2 years ago

Good news! It still happens, but there were things I did that stopped it.

First of all, it happened this morning. I have Blueman installed, but with all autoconnection turned off. Anyway, I thought I'd try one more time without (I'd already tested to see if that was at fault by completely uninstalling it. This time, I just exited) - first run after exiting Blueman it worked! But, since sometimes it has worked then not worked, I decided to exit QZ and try again. Result = segmentation fault again. So not directly Blueman's fault, but may be related.

So, now that it wasn't working, I tried a few more times. Just exiting and re-starting QZ. Always segmentation fault. So I turned off my heart rate monitor and next run of QZ, it worked! Then I left the heat rate monitor on and restarted QZ and it still worked! Several goes later, it was still working.

It isn't just that one heart rate monitor - another one does it, but that one I can't turn off and on so easily.

This was all without rebuilding QZ. All I was doing was exiting and restarting.

Very strange, because I really thought it was fixed after I stopped editing main.xml

Anyway, don't waste your time thinking about this, I just wanted to update you. If it happens again, I'll just video the whole thing and send logs and maybe that'll help.

cagnulein commented 2 years ago

maybe I got it @jonathancolledge are you still using the branch raspberry? the one that I created for you? If so I will add some debug output to confirm my idea.

jonathancolledge commented 2 years ago

Yeah I can use that, pull and build again? I'll try tomorrow, or I'll try and start a video of the fan!

cagnulein commented 2 years ago

let me do the modification first :P

cagnulein commented 2 years ago

done @jonathancolledge

jonathancolledge commented 2 years ago

Working debug file. No problems here. Heart rate monitor off before I started QZ.

debug-Sat_May_14_05_22_35_2022.log

jonathancolledge commented 2 years ago

NOT working debug. Only difference is that I turned the heart rate monitor on before starting QZ. But after this I can't get it to work even with heart rate monitor off. I'll keep trying... [UPDATE: I have now got it back working. It looks like once the heart rate monitor breaks it, then any deice is a problem, so I had to unplug my Kickr to make QZ start].

debug-Sat_May_14_05_23_03_2022.log

cagnulein commented 2 years ago

after the non working debug you got a segmentation fault isn't it @jonathancolledge ? if so i got it clearly! i will fix it today, it should be easy

jonathancolledge commented 2 years ago

Yes, also see the update above. But to update the update, I then plugged the Fitfan in before starting Qz and it broke again. Now segmentation fault every time even with all devices unplugged.

cagnulein commented 2 years ago

ok got it. i will fix on the afternoon. thanks

cagnulein commented 2 years ago

done @jonathancolledge pull it and build it. finger crossed!

jonathancolledge commented 2 years ago

Almost! Heart rate didn't connect

debug-Sat_May_14_06_52_15_2022.log

cagnulein commented 2 years ago

@jonathancolledge but it doesn't crash anymore, isn't it?

jonathancolledge commented 2 years ago

That's right! Doesn't crash!

cagnulein commented 2 years ago

@jonathancolledge this is the issue


Sat May 14 06:52:36 2022 1652511156732 Debug:   Cannot find targeted remote device. Re-running device discovery might help
Sat May 14 06:52:36 2022 1652511156734 Debug: bluetooth.cpp void bluetooth::debug(const QString&) "heartratebelt::errorUnknownRemoteDeviceErrorRemote device cannot be found"

did you try just one time or is it deterministic?

jonathancolledge commented 2 years ago

did you try just one time or is it deterministic?

I tried 3 times yesterday, but I think I just needed to turn it all off then on because today, it is perfect! All connecting. Heart rate working, tiles showing, and Fitfan working! Thank you!

cagnulein commented 2 years ago

great! let's see if it is steady!

jonathancolledge commented 2 years ago

debug-Tue_May_17_04_41_50_2022.log

Today it took a lot of tries to connect to heart rate, but it did in the end. What it never connected to was the Fitfan. I was displaying the intended fan speed though.

cagnulein commented 2 years ago

@jonathancolledge for the FAN: I didn't see the advertising frame from the fan here. Are you sure it's not connected to your phone?

for the HR: it seems a DBUS issue. Did you try to reboot the raspberry?

jonathancolledge commented 2 years ago

Maybe it was the reboot. Connections all fine this morning. Though I sent you other news on messenger.

cagnulein commented 2 years ago

yeah bluetooth is very weak on linux. so i suggest always to start with a fresh boot

cagnulein commented 2 years ago

@jonathancolledge check the last point of this also https://github.com/cagnulein/qdomyos-zwift/wiki/FAQ

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cagnulein commented 2 years ago

@jonathancolledge what about this issue? can we close this?

jonathancolledge commented 2 years ago

Yes indeed!

cagnulein commented 1 year ago

argh unbelievable! so sorry to hear this :(

Il giorno mer 13 apr 2022 alle ore 19:47 jonathancolledge < @.***> ha scritto:

The plot thickens - my micro sd card is bent and the whole thing won't boot now. I don't know if that happened before or after, anyway I will reinstall. If I can replicate the bug then we can continue, if not, it may have been some corruption on my sd card.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/769#issuecomment-1098322702, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWHK2M5DSKZVB2GPGITVE4CDTANCNFSM5TJO6VUQ . You are receiving this because you were assigned.Message ID: @.***>