cagnulein / qdomyos-zwift

Zwift bridge for smart treadmills and bike/cyclette
https://www.qzfitness.com/
GNU General Public License v3.0
344 stars 105 forks source link

Debug log using qdomyos on a proform Tour de France 10.0 bike #877

Closed henryvandevorst closed 1 year ago

henryvandevorst commented 1 year ago

Hi,

As requested on facebook, I post the debug log of connecting qdomyos (running on Apple iPhone 12pro with iOs 15.1) to my Proform Tour de France 10.0 bike.

Best regards, Henry debug-zo_jul__31_14_54_46_2022.log

henryvandevorst commented 1 year ago

Hi, I don't know how to get the screen from comment #1010. Also, I usually do not have the inclination and resistance indicators on my screen (that is optional). Apart from that I can change resistance and inclination with touch buttons on the console or with the handles on the steering wheel. So I don't understand why this is needed.

victorypoint commented 1 year ago

@henryvandevorst, I've added a new batch file called "adb-screenshot.bat" to the install package at https://github.com/cagnulein/QZCompanionNordictrackTreadmill/tree/master/InstallPackage to help you with the screen coordinates. Run the batch after making an ADB connection and it will take a screenshot of your tablet display and save it to your PC.

Before taking the screenshot, make sure to prepare the tablet display by starting a manual workout - have the on-screen controls displayed, and set speed and incline so you can see the lowest and highest boxes of the speed and incline sliders.

Once you have a screenshot, you will need to determine:

Let us know if you need any further information. -Al

cagnulein commented 1 year ago

Apart from that I can change resistance and inclination with touch buttons on the console or with the handles on the steering wheel. So I don't understand why this is needed.

this is needed because it's the only way how qz can interact with inclination and resistance. QZ will simulate a manual changed using the QZ requests

Thanks @victorypoint very helpful!

henryvandevorst commented 1 year ago

@cagnulein, see info in attached files. screenshot results.txt do15-12-2022@10-28-39,51

cagnulein commented 1 year ago

thanks @henryvandevorst changing the inclination, makes also the resistance harder on your bike? or they are separate?

cagnulein commented 1 year ago

TDF10.xlsx so: Inclination X: 74 Y: -12,2 * inclination_level + 482

Resistance X: 1205 Y: -19,263 * inclination_level + 623,26

cagnulein commented 1 year ago

@henryvandevorst this is the new apk for your bike https://github.com/cagnulein/QZCompanionNordictrackTreadmill/suites/9883144415/artifacts/477151549

  1. install it replacing the current one
  2. run it and select the model of your bike
  3. restart it
  4. open then the ifit app on top
  5. open qz and change the resistance from the tile.

if i did everything right you should see the movement of the resistance slidebar in the ifit app

Let me know

henryvandevorst commented 1 year ago

thanks @henryvandevorst changing the inclination, makes also the resistance harder on your bike? or they are separate?

@cagnulein: Whe the inclination goes up up, I get a higher resistance, even when the resistance setting stays at its lowest. Quite realistically like driving up a mountain without changing gears. So driving in the highest inclination is quite heavy, even with the resistance at its lowest. I can make it even harder by increasing the resistance. By the way: Inclination goes bij half steps (0 - 0,5 - 1 - 1,5 etc), resistance in whole steps.

cagnulein commented 1 year ago

ok @henryvandevorst let's check the actual implementation that I did. I can change it to the inclination if it works

henryvandevorst commented 1 year ago

@cagnulein this is a app-debug.apk, currently I have QZCompanionNordictrackTreadmill.apk installed. Is that ok and should I just rename it?

cagnulein commented 1 year ago

@henryvandevorst it's ok, the filename is only a description, you can install it as it is

henryvandevorst commented 1 year ago

@cagnulein But I need to rename it if I want to install with the .bat file, or not?

cagnulein commented 1 year ago

@henryvandevorst yes if you need to install it with the batch file you need to rename it or you can download the whole package https://github.com/cagnulein/QZCompanionNordictrackTreadmill/tree/master/InstallPackage

henryvandevorst commented 1 year ago

Did a first short try after installing the new app. The IOS apps does connect, but I get no results at all, everything stays at zero. Are there any settings I need to change?

cagnulein commented 1 year ago

@henryvandevorst did they work before with the previous one? are all the permissions ok in the companion app? in case share a adb logcat (from the main screen of the companion you will find the button to generate it)

henryvandevorst commented 1 year ago

Yes, all worked ok. How can I set permissions in the companion app? I will try to make a logcat later (having some busy days ahead)...

cagnulein commented 1 year ago

@henryvandevorst the permissions are in the settings of the tablet (app menu if i remember correctly). It's the only thing that could cause this I guess

victorypoint commented 1 year ago

@henryvandevorst, excellent work with the tablet screenshot and getting the screen coordinates!

So very important - the companion app needs to launch after ADB Debugging is enabled on the tablet. So after the treadmill reboots, be sure to enable ADB Debugging and run the new batch file in the install package - QZ-Companion-restart.bat.

henryvandevorst commented 1 year ago

@Cagnulein, I found an error in the textfile that I send with the screenshot. The range for resistance is NOT 1-20, but 1-24. You can see it on the screenshot, but it is wrong in the text.

henryvandevorst commented 1 year ago

Since installing the new companion app on my bike I get no info on the Qdomyos app on ios. There seems to be a connection, but no other info. I restarted the comapion app as @victorypoint suggested but no result. Permissions (the companion app asks for storage permission) are set. Are there any settings in the IOS app that need to be changed,

cagnulein commented 1 year ago

@cagnulein, I found an error in the textfile that I send with the screenshot. The range for resistance is NOT 1-20, but 1-24. You can see it on the screenshot, but it is wrong in the text.

ok so this is the updated formula

image

let me implement this

cagnulein commented 1 year ago

@henryvandevorst are you able to send me the logcat generated from the button on the companion? remember to do it while the workout is running Thanks

cagnulein commented 1 year ago

@henryvandevorst new qz companion version with the new formula https://github.com/cagnulein/QZCompanionNordictrackTreadmill/releases/tag/3.0.11

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cagnulein commented 1 year ago

@henryvandevorst any news?

henryvandevorst commented 1 year ago

No changes here. I get no info from te bike to the app. Will try to make a debug log next week.Op 5 jan. 2023 om 16:03 heeft Roberto Viola @.***> het volgende geschreven: @henryvandevorst any news?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

cagnulein commented 1 year ago

ok let me know, in these days i'm starting writing the code directly on qz to read the metrics without the companion. i can start from your bike so

henryvandevorst commented 1 year ago

@cagnulein Hi, did som testing today. I got a connection, and everything seems to be working (cadence, speed etc). It seems the connection only happens after I started a workout. 2 obeserations though: (1) The inclination goes from -10% to +20% in increments of 0.5%. The app only shows whole numbers, so 1%, 2%. So I have to click 2 times to see the increment. So when the bike show 10% and I go up 0,5% the app still shows 10%. When I go up to 11% the app shows 11% correctly. (2) The resistance goes from 1 to 24 in whole step increments. There the app seems to work with 0,5 step increment. So a resistance of 12 is show as 6.

I attached the debug log. debug-ma_jan__16_09_38_38_2023.log

cagnulein commented 1 year ago

after I started a workout

@henryvandevorst even only a manual one? if so yes it's the way to do it

The inclination goes from -10% to +20% in increments of 0.5%. The app only shows whole numbers, so 1%, 2%. So I have to click 2 times to see the increment. So when the bike show 10% and I go up 0,5% the app still shows 10%. When I go up to 11% the app shows 11% correctly.

I guess I got the issue. Is the "," the decimal separator on your phone?

The resistance goes from 1 to 24 in whole step increments. There the app seems to work with 0,5 step increment. So a resistance of 12 is show as 6.

ok let me check this

cagnulein commented 1 year ago

@henryvandevorst i checked the resistance thing and in this log i saw only resistance from the bike directly went from 0 to 6. But it's ifit directly that it sends me this. No 0,5 increments, only 0-1-2-3-4-5-6

Maybe ifit inside, is rounding it and using it from a 0 to 6 levels? if you want you can redo this test with a debug log. Let me know!

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cagnulein commented 1 year ago

@henryvandevorst any news?

henryvandevorst commented 1 year ago

I did a short workout today where I switched all the way up to an inclination of 20%. Whenever the screen of the bike gives an inclination of say 0,5 1,5 2,5 etc the app shows zero. When the inclination is a whole numer the app shows the correct inclination. Looking at the resistance I went all the way up to 24 (in whole number increments). But the app came only to 15. Resistance of 12 on the bike gives 8. So about two thirds. I attachted the debug log. debug-wo_feb__8_09_41_51_2023.log

cagnulein commented 1 year ago

@henryvandevorst I saw that you're still using the stable version of qz, send me an email to roberto.viola83 at gmail.com indicating this ticket and if you are on android or iOS and I will send you the beta one where I already tried to fixed the decimal point. For the resistance instead, your bike is sending me gear and resistance. The value that i see for 24 is about gear not resistance. So do you want to swap gear with resistance in QZ?

henryvandevorst commented 1 year ago

@robertoviola I think it is best to change resistance to gear. I think the bike calculates resistance from the combination of gear and inclination. Does that sound logical to you?

Van: Roberto Viola @.> Verzonden: woensdag 8 februari 2023 11:03 Aan: cagnulein/qdomyos-zwift @.> CC: henryvandevorst @.>; Mention @.> Onderwerp: Re: [cagnulein/qdomyos-zwift] Debug log using qdomyos on a proform Tour de France 10.0 bike (Issue #877)

@henryvandevorst https://github.com/henryvandevorst I saw that you're still using the stable version of qz, send me an email to roberto.viola83 at gmail.com indicating this ticket and if you are on android or iOS and I will send you the beta one where I already tried to fixed the decimal point. For the resistance instead, your bike is sending me gear and resistance. The value that i see for 24 is about gear not resistance. So do you want to swap gear with resistance in QZ?

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/877#issuecomment-1422336688 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ATNTR7P24YISZFRMTBXXPJ3WWNVMZANCNFSM55E4UQYA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ATNTR7PQ3AX2RS4Y2FKKLCDWWNVMZA5CNFSM55E4UQYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOKTDSFMA.gif Message ID: @. @.> >

cagnulein commented 1 year ago

ok, i don't know if this will apply to all the proform bikes. I always thought that gears are like the gears on a real bike, and resistance is coming from inclination...maybe i'm wrong?

henryvandevorst commented 1 year ago

I think it is logical that you try to model a real bike. What I would expect is that a bike feels like giving more resistance when driving with the same gear up a mountain as compared to the same gear on a flat road. So I think resistance comes from the combination of gear and inclination. When climbing a mountain changing to a lighter gear gives less resistance (but of course also less distance travelled). What are your thoughts on this?

Van: Roberto Viola @.> Verzonden: woensdag 8 februari 2023 13:46 Aan: cagnulein/qdomyos-zwift @.> CC: henryvandevorst @.>; Mention @.> Onderwerp: Re: [cagnulein/qdomyos-zwift] Debug log using qdomyos on a proform Tour de France 10.0 bike (Issue #877)

ok, i don't know if this will apply to all the proform bikes. I always thought that gears are like the gears on a real bike, and resistance is coming from inclination...maybe i'm wrong?

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/877#issuecomment-1422540102 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ATNTR7PT2FKGSMKDGN333QLWWOIRVANCNFSM55E4UQYA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ATNTR7N7G2PER3JPBILYWC3WWOIRVA5CNFSM55E4UQYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOKTFD2RQ.gif Message ID: @. @.> >

cagnulein commented 1 year ago

ok it makes sense, i'm changing it. Let's see if someone will say something against this :)

henryvandevorst commented 1 year ago

Hi, tried with the version you send me via email. Inclination no shows with half steps, so that is ok. I think you are still working on the gears / resistance issue. I saw that there is also a gears tile in the app. The bike (see the debug file) has values for resistance, gear and inclination. I was looking at resistance, expecting it would represent the gear setting. But resistance seems to be calculated by the bike (i think) from gear and inclination. If that is true you do not have to change resistance to gear, because the bike already delivers those values. I just have to put the gear tile next to inclination and resistance if I want to see all of them. Does that make sense?

cagnulein commented 1 year ago

Hi, tried with the version you send me via email. Inclination no shows with half steps, so that is ok.

@henryvandevorst ok perfect!

I think you are still working on the gears / resistance issue.

@henryvandevorst no, I set the gears as resistance as you suggested me. Send me a debug log to confirm me this. Thanks

I saw that there is also a gears tile in the app.

@henryvandevorst the gears tile has another use. With the gears tile you can override the current resistance requested from zwift, in order push up or down the resistance momentarily

The bike (see the debug file) has values for resistance, gear and inclination. I was looking at resistance, expecting it would represent the gear setting.

The gear, in this version, will be displayed in the resistance tile.

But resistance seems to be calculated by the bike (i think) from gear and inclination. If that is true you do not have to change resistance to gear, because the bike already delivers those values. I just have to put the gear tile next to inclination and resistance if I want to see all of them. Does that make sense?

No I guess there is a little of confusion :) Let's send me a new debug log so I can check that all I did is matching the behavior of the bike. Thanks :)

henryvandevorst commented 1 year ago

@cagnulein Hi, did some more testing on the relation between gear (as set on the bike), inclination and resistance. Some observations:

  1. Gear is reported, but only when you change gear. After that gear is reported as 0 until the next gear change.
  2. When the inclination is negative resistance is 0
  3. I went through all (positive) inclinations with a few gear settings (1, 5 and 10) and that shows that resistance is indeed dependent on the combination of gear and inclination (for example Inclination 10 with gear 1, 5 and 10 reports a resistance of 8, 10 and 13 respectively. See the added excel in which I extracted the reported data from the bike in the debug log.

Proform Gear - Inclination - Resistance.xlsx

henryvandevorst commented 1 year ago

@cagnulein, and the debug logs I used for the excel. debug-wo_feb__22_11_45_56_2023.log debug-ma_feb__20_09_46_13_2023.log

cagnulein commented 1 year ago

please share also a debug log @henryvandevorst showing the gear issue. thanks

cagnulein commented 1 year ago

hah ok saw now. thanjs

cagnulein commented 1 year ago

@henryvandevorst I don't think the iOS version is the last build that I sent you with the gear fix. Just to be sure I sent the last one, just let me know if you're experiencing the same things

henryvandevorst commented 1 year ago

Hi, is the new version in testflight?

Van: Roberto Viola @.> Verzonden: woensdag 22 februari 2023 14:55 Aan: cagnulein/qdomyos-zwift @.> CC: henryvandevorst @.>; Mention @.> Onderwerp: Re: [cagnulein/qdomyos-zwift] Debug log using qdomyos on a proform Tour de France 10.0 bike (Issue #877)

@henryvandevorst https://github.com/henryvandevorst I don't think the iOS version is the last build that I sent you with the gear fix. Just to be sure I sent the last one, just let me know if you're experiencing the same things

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/877#issuecomment-1440055532 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ATNTR7KH4VKO23Y6D2AB2YDWYYLDTANCNFSM55E4UQYA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ATNTR7IDMFC7GAJGLB5BDSTWYYLDTA5CNFSM55E4UQYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOKXKYB3A.gif Message ID: @. @.> >

cagnulein commented 1 year ago

@henryvandevorst yes, i just send you an email, build 498 or above

henryvandevorst commented 1 year ago

@cagnulein Did a new test today. In the app the gear is now shown in the resistance field. In the debug log gear as reported by the bike only shows when changing gear, then it goes to 0 until the next gear change. See debug log. App version is 2.12.70 (498) according to Testflight. debug-do_feb__23_13_40_20_2023.log

cagnulein commented 1 year ago

In the debug log gear as reported by the bike only shows when changing gear, then it goes to 0 until the next gear change. See debug log. App version is 2.12.70 (498) according to Testflight.

yes it's perfect no? I mean the resistance tile is keeping the value, right?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.