search

cagov / caldata-infrastructure-template

Template for bootstrapping MDSA projects
MIT License
1 stars 0 forks source link

Should we remove BigQuery from this project? #38

Closed britt-allen closed 4 weeks ago

britt-allen commented 2 months ago

We no longer use BQ and there are still lots of references to it in this repo. A file was randomly removed that caused CI to start breaking in https://github.com/cagov/caldata-infrastructure-template/pull/36 so we deleted a couple of references to get CI working again, but there is still stale code mentioning BQ. What to do?

Note to self: pay special care to if/else blocks

jkarpen commented 2 months ago

@britt-allen how big of a cleanup job would it be to go through and remove those references? is it a lot of code or just a few places?

britt-allen commented 2 months ago

A quick search shows there are 26 results in 9 files so it should be fairly small. I can bump the size down to small

Screenshot 2024-08-22 at 12 11 27 PM
britt-allen commented 2 months ago

I wanna discuss with Ian first to see if we want to remove and no longer support it or if we want to fix the issue that was causing CI to break and continue investing in BQ.

jkarpen commented 2 months ago

Got it, OK lets keep it in the backlog for now then.

jkarpen commented 1 month ago

Adding this to 2024-20 sprint as a reminder to talk to Ian about it when he returns.

ian-r-rose commented 1 month ago

I'm in favor of removing it! It will significantly simplify the template. If we ever need to restore it, it will be in the git history

ian-r-rose commented 1 month ago

Sorry, misclick