cagov / data-infrastructure

CalData infrastructure
https://cagov.github.io/data-infrastructure
MIT License
7 stars 0 forks source link

Convert pre-commit GitHub action to Azure Pipelines - Pipeline Creation & Testing #437

Open ram-kishore-odi opened 1 day ago

ram-kishore-odi commented 1 day ago

We currently drive CI through GitHub actions. We need to convert that to Azure Pipelines for the Azure DevOps flavored MDSA project repo. This is the second ticket related to pre-commit Github action conversion to Azure pipeline. This ticket takes care of adding a sample pipeline and testing this functionality.

The first ticket related to this is https://github.com/orgs/cagov/projects/31/views/39?sliceBy%5Bvalue%5D=ram-kishore-odi&pane=issue&itemId=84385198&issue=cagov%7Ccaldata-dse-internal-tracker%7C20. which takes of the conversion portion

summer-mothwood commented 1 day ago

Ran into this while researching dbt Cloud updates -- dbt Cloud has new merge jobs that are meant to remove the necessity for some Github actions. This couldn't take the place of all of our Github Actions as it's pretty limited, but might be worth a look:

Merge jobs for implementing continuous deployment (CD) workflows are now GA in dbt Cloud. Previously, you had to either set up a custom GitHub action or manually build the changes every time a pull request is merged.

ian-r-rose commented 1 day ago

Yeah, it may be that we can remove the pre-commit action all-together now that dbt cloud CI jobs can run sqlfluff.

We do other checks in the pre-commit job:

That said, sqlfluff is the most important for a dbt-focused project, and the simplification gained for clients who don't want to maintain a YAML CI pipeline might be worth the trade-off

ian-r-rose commented 1 day ago

I would still like to have the option of an Azure pipeline CI job for clients who don't want to adopt dbt Cloud, but being able to run sqlfluff in dbt Cloud would take some of the time pressure off