cagov / design-system

State of California Design System
MIT License
81 stars 25 forks source link

A different approach page index link not work for "Use your..." #463

Closed wrendo closed 2 years ago

m-sullivan7 commented 2 years ago

This is potentially due to the presence of a comma in the H2 that isn't working. This could be solved in one of two ways:

This decision will also likely affect https://github.com/cagov/design-system/issues/462

chachasikes commented 2 years ago

Thanks Michael . There is support already for punctuation handling.

There may be another issue if you had been testing on Windows - the prefers motion accessibilty option may be in effect on those devices. I'm working on that.

m-sullivan7 commented 2 years ago

Cool! Based on what I see in https://github.com/cagov/design-system/issues/462, question mark should probably be added too. Thanks!

chachasikes commented 2 years ago

I tracked down what was going on here. Sharing some notes on this thread.

Context: For our anchor tags, I decided to strip punctuation and special characters. In the code you can see the two RegEx expressions.

When originally working on this, had some plans to build multilingual test cases, that will still be helpful.

For now, will continue with this plan of stripping out commas and special punctuation for the anchor links.