cagov / design-system

State of California Design System
MIT License
79 stars 25 forks source link

Bug: Contact form not working #976

Closed zakiya closed 8 months ago

zakiya commented 1 year ago

Urls where issue was found

designsystem.webstandards.ca.gov

designsystem.webstandards.ca.gov/contact-us

Steps to reproduce

Fill out the form and hit submit

Expected result

Submission appears at https://airtable.com/app4B5KqaCTSHAdCS/tbliV5kSgz7jBnIyT/viwDkwTUo3wZOqYhF?blocks=hide Emails are sent to Yesenia and Chach.

Acceptance criteria

Optional criteria

CC: @chachasikes @YeseniaGtz

xjensen commented 1 year ago

The form is working again. Aaron's Airtable Personal Access Token was disabled along with his account. Swapping to another Personal Access Token fixed the issue.

These Airtable Personal Access Tokens will not be depreciated on 2/1/2024; they're removing a different type of API key. Nonetheless, it's still a good idea to migrate to OAuth, as this ticket demonstrates.

The OAuth migration will require some real work. It's a nice little project.

YeseniaGtz commented 1 year ago

Thanks for taking care of this!

On Wed, Jul 12, 2023 at 11:36 AM Jon Jensen @.***> wrote:

The form is working again. Aaron's Airtable Personal Access Token was disabled along with his account. Swapping to another Personal Access Token fixed the issue.

These Airtable Personal Access Tokens will not be depreciated on 2/1/2024; they're removing a different type of API key. Nonetheless, it's still a good idea to migrate to OAuth, as this ticket demonstrates.

The OAuth migration will require some real work. It's a nice little project.

— Reply to this email directly, view it on GitHub https://github.com/cagov/design-system/issues/976#issuecomment-1633026074, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5NV6F4YZTPUCBNX6I4ER4TXP3VCLANCNFSM6AAAAAA2GSDPJY . You are receiving this because you were mentioned.Message ID: @.***>

--

Yesenia Gutierrez (She/Her)

Product Manager | CA Office of Data and Innovation

(916) 562-4893 | @.***

Follow us: web https://innovation.ca.gov/ | blog https://innovation.ca.gov/blog/ | twitter https://twitter.com/californiaodi

Schedule a meeting with me https://calendly.com/yesenia-gutierrez-odi

zakiya commented 1 year ago

Here's a quote from the email I got about API keys

The timeline for the Airtable API key deprecation is below:

February 2023: Provided API Key deprecation notice August 1st, 2023: Users will no longer be able to create new API keys February 1st, 2024 (next year): Existing API keys cannot be used to access the Airtable API

I'll forward you the whole email @xjensen

xjensen commented 1 year ago

Got the email, thanks!

Aaron already did the work to replace the legacy API key with the newly supported Personal Access Token. I got my info about the Personal Access Tokens at this page. I believe he included this change when he converted the FaaS from Azure to AWS.

It's still a problem though, because his token expired when he left. (No fault of his, of course. Now we know.) So OAuth is still on the table as essential work IMO.

zakiya commented 8 months ago

@xjensen Have you had time to work on OAuth? Should I assign to someone else?

xjensen commented 8 months ago

@zakiya Nope, haven't worked on OAuth integration of the form.

At this point, I imagine it would be easier to just get a new Personal Access Token from our shared odi-engineering Airtable service account, so that it's not tied to my account. That would alleviate a lot of the concerns I had before about continuity of service.

But happy to look into it if OAuth is still desired.

zakiya commented 8 months ago

We removed the contact forms from the design system. Closing.