search

cagov / odi-engineering

California Office of Digital Innovation engineering documentation
MIT License
2 stars 0 forks source link

Propagate production install flag to all repos #54

Closed aaronhans closed 1 year ago

xjensen commented 2 years ago

@aaronhans Was this issue about replacing npm install with npm ci --production in all of our GitHub Action deployment scripts?

aaronhans commented 2 years ago

yes, thanks for implementing this in some places already @xjensen

zakiya commented 2 years ago

@xjensen @aaronhans Can you list out where this is implemented and were it isn't?

xjensen commented 2 years ago

We have it on Drought already. I believe we still want it on Digital and Cannabis.

Here's some background for posterity. The purpose of npm ci --production is to prevent installation of devDependencies during production builds. This can significantly speed up publication time and prevent some errors. The challenge is rearranging the dependencies/devDependencies in package.json to ensure everything works as expected in all environments.

zakiya commented 2 years ago

Note to self: Create individual issues in the cannabis and innovation repos once they've been cleaned up a bit

zakiya commented 1 year ago

Going to close this. We can do this with future projects as needed.