Enforce Required API Fields - Githubissues

cagov / ui-claim-tracker

This repo contains the Claim Status Tracker app, which helps Californians better understand what’s happening with their unemployment claim and benefits.

9 stars 4 forks source link

Enforce Required API Fields #538

Closed lomky closed 2 years ago

lomky commented 3 years ago

Removes the optional nature of the fields the API always returns, and simplifies some logic enabled by this.

All changes are a straight refactor - tests should all still pass, snapshots should be unaffected, testing in browser & storybook should not fail.

===

Resolves #524

[x] Simplify business logic if BYE is garunteed
[x] Update base API response expectations
[x] Manual Browser Testing performed (with modheader, either locally or on BrowserStack)