search

caguiclajmg / platelet-clicker

くすぐったいよ
https://platelets.fun
26 stars 6 forks source link

Cross-browser Audio #4

Closed caguiclajmg closed 5 years ago

caguiclajmg commented 5 years ago

Some browsers don't have Vorbis support (IE, iOS/Safari, etc.) and are left with no audio. Just need to add additional source fallbacks (MP3 and AAC seem like good candidates).

This would also be the best time to move the audio part into <audio> tags instead of loading them in JS (IMO this would be cleaner than adding source fallbacks via JS).

caguiclajmg commented 5 years ago

Partially fixed by https://github.com/caguiclajmg/platelet-clicker/commit/f741b036c7a2163294f07277124295382936251c, didn't move the reactions into <audio> tags as it could easily get ugly if a lot of reactions are added; in that case loading the audio via a loop in js would be a cleaner solution.

caguiclajmg commented 5 years ago

Fixed by #6