search

cah011 / binja-avr

AVR assembly plugin for Binary Ninja
MIT License
12 stars 11 forks source link

perform_get_instruction_info - src value undefined #9

Closed lucasduffey closed 7 years ago

lucasduffey commented 7 years ago

In the perform_get_instruction_info function I'm getting "src is undefined"

elif (instr == 'brbs' or instr == 'brbc'):
    result.add_branch(BranchType.TrueBranch, addr + src*2 + 1*2)
    result.add_branch(BranchType.FalseBranch, addr + 1*2)

I assumed it might be src_value instead, but I get another error when I replace src with src_value

lucasduffey commented 7 years ago

maybe it should be dst?

relevant pull request: https://github.com/cah011/binja-avr/pull/10

cah011 commented 7 years ago

Indeed this is the case, merged. f293f49