timothy1ee
commented
10 years ago Good work. You should be aiming for a higher level of polish. You'll find that it's technically non-trivial and worth the effort.
- Your filters tableview can't scroll all the way to the bottom, probably means you didn't have Auto Layout set up properly.
- Your cells stay selected after being tapped.
- Your expandable section keeps the "More" cell in it even after expansion.
- You don't need to specify relative paths for your headers.
- You didn't use the cell registration method which will lead to poor scrolling performance of your tableviews.
Hopefully, you're becoming a bit more comfortable with the framework and the conventions. If so, for the next assignment, you should try to challenge yourself on the UI/visual side of things. Try to challenge yourself to implement polish features that you see in the app store. Not necessarily flashy things, but it's the small details that take a lot of work.
The purpose of this assignment was to explore the following:
- Table views with dynamic height rows and custom cells with Auto Layout.
- Table views that contain controls for user input and binding those controls to form data.
- Advanced features of table views such as row animation and section views.
- Linking two view controllers view a custom delegate pattern.
Here's my checklist as I'm reviewing the submissions:
- Code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
- Custom cells.
- Are the subviews of the cell exposed in the public header or are they properly encapsulated?
- Do the nibs have the proper Auto Layout constraints?
- Are the cells registered with the table view?
- Filter view controller
- Are the controls properly bound with the form data?
- Is there a custom delegate to notify the search view controller of new filter settings?
- Is there a section in the table view that accordians out?
/cc @timothy1ee
Hoped to get more accomplished... switch that seemed so elegant really bit me .