search

cai567890 / pcsx2

Automatically exported from code.google.com/p/pcsx2
1 stars 0 forks source link

[i18n] Missing entries in POT-file #915

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
1. CDVD -> iso -> Browse cannot be translated
2. Description for About option
3. Print CDVD info cannot be translated
4. Show console cannot be translated
5. About dialog info can't be translated (Developers/contributors)
6. Configuration Wizard always in english
7. Some panels missing

Original issue reported on code.google.com by zantezuken@gmail.com on 10 Dec 2010 at 10:30

GoogleCodeExporter commented 9 years ago 
on r4426

I checked my comment #10 for "Please select a valid plugin for the %s."

the string is in:
http://pcsx2.googlecode.com/svn/trunk/pcsx2/gui/Panels/PluginSelectorPanel.cpp

the line include the string:
.SetUserMsg(pxsFmt( L"Please select a valid plugin for the %s.", 
plugname.c_str() ) + L"\n\n" + GetApplyFailedMsg() );

But the string can't be translated even though I put it into msgid and 
translation into msgstr. I guess the prefix L before string indicates a string 
can not be translated literally.

Original comment by pcsx2fan@gmail.com on 13 Mar 2011 at 8:13

GoogleCodeExporter commented 9 years ago 
Translated (to pt_BR, in my case) message in the Console / Program Log window ? 
I thought this window should stay untranslated.

This happened when I accidentally dragged and dropped my firefox shortcut to 
pcsx2's.

(Sorry. This is the opposite of missing, but I guess it won't harm to mention 
this issue in this opened thread)

Original comment by rafael.f...@gmail.com on 28 Mar 2011 at 11:50

Attachments:

GoogleCodeExporter commented 9 years ago 
To Comment 8:

I tested that "PCSX2 Message" can be translated.

the string in http://code.google.com/p/pcsx2/source/browse/trunk/pcsx2/System.h

Change all 3 L"PCSX2 Message" to _("PCSX2 Message")

Original comment by pcsx2fan@gmail.com on 29 Mar 2011 at 6:09

GoogleCodeExporter commented 9 years ago 
Rafael I spotted the issue. The dev string is translated instead of the user 
ones. I will fix that later.

Original comment by gregory....@gmail.com on 29 Mar 2011 at 8:49

GoogleCodeExporter commented 9 years ago 
r4512:
The translation of "Automatic Gamefixes", a string placed in the Main 
translation file, doesn't work. "Automatic Gamefixes" is displayed in the 
"System" menu of PCSX2.

Original comment by pg...@yahoo.se on 30 Mar 2011 at 1:40

GoogleCodeExporter commented 9 years ago 
Hmm, I see no reason why this string should not be translatable.
It's the same code as for "Shutdown" for example..

Original comment by ramapcsx2 on 30 Mar 2011 at 2:05

GoogleCodeExporter commented 9 years ago 
Well in my opinion, it could be a po issue too. I confirm it when I get an 
access to my computer.

Original comment by gregory....@gmail.com on 30 Mar 2011 at 2:36

GoogleCodeExporter commented 9 years ago 
pg can look to your po file. And check the string is not mark fuzzy.

Original comment by gregory....@gmail.com on 30 Mar 2011 at 4:45

GoogleCodeExporter commented 9 years ago 
Nothing weird in the .po as far as I can tell.

#: pcsx2/gui/MainFrame.cpp:419
msgid "Automatic Gamefixes"
msgstr "Automatiska Spelfixar"

Original comment by pg...@yahoo.se on 30 Mar 2011 at 5:17

GoogleCodeExporter commented 9 years ago 
I resync po file on my side. This string appears fuzzy, I delete the fuzzy. I 
launch pcsx2 and the string was properly translated. Maybe your po is not sync 
with the code.

Original comment by gregory....@gmail.com on 30 Mar 2011 at 5:29

GoogleCodeExporter commented 9 years ago 
I solved it.
I relied to much on EMUCR.
It works as it should.
Now all that troubles is that updating the Tertiary file causes errors.
"Entries in catalog are probably incorrect."

Original comment by pg...@yahoo.se on 30 Mar 2011 at 6:56

GoogleCodeExporter commented 9 years ago 
PS to my previous note:
The error with the Tertiary file is as far as I can tell caused by 
"!ContextTip:Gamefixes:DMA Busy hack".
It's still present in r4517.

Original comment by pg...@yahoo.se on 31 Mar 2011 at 7:15

GoogleCodeExporter commented 9 years ago 
Hum, it might be due to extra \n at beginning or end

Original comment by gregory....@gmail.com on 31 Mar 2011 at 7:39

GoogleCodeExporter commented 9 years ago 
{
    _("Ignore DMAC writes when it is busy."),
    pxEt( "!ContextTip:Gamefixes:DMA Busy hack",
        L"Known to affect following games:\n"
        L" * Mana Khemia 1 (Going \"off campus\")\n"
    )
}

Please don't tell me it complains about the last \n ><

Original comment by ramapcsx2 on 31 Mar 2011 at 9:16

GoogleCodeExporter commented 9 years ago 
The update of the Tertiary file was caused by the 2 configstring mention 
earlier.
After I removed them the update worked, however when saving it, Poedit 
generates an error. After I removed the "\n" from the last string of the 
translation it worked.
It doesn't have to be removed from the "GameFixesPanel.cpp" file.
Now however, I can't make Poedit accept the 2 config strings again, after I 
inserted them manually into the Tertiary file, and they won't do any good if I 
use them anyway with PCSX2.
Oh well...

Original comment by pg...@yahoo.se on 31 Mar 2011 at 10:32

GoogleCodeExporter commented 9 years ago 
I will update/upload pot,po with latest change (in ~10hours). Maybe with a 
clean po or pot it will work better. In my opinion it is a very bad idea to 
manually add string into the .po

Original comment by gregory....@gmail.com on 1 Apr 2011 at 8:28

GoogleCodeExporter commented 9 years ago 
Just switching gregory to own this issue, since Jake isn't on the project, and 
greg was the one working on it...

Original comment by arcum42@gmail.com on 2 Nov 2011 at 4:27

GoogleCodeExporter commented 9 years ago 
Suggestions about i18.cpp:
*
Make
 LANGUAGE_FRENCH_BELGIAN
 LANGUAGE_FRENCH_CANADIAN
 LANGUAGE_FRENCH_LUXEMBOURG
 LANGUAGE_FRENCH_MONACO
 LANGUAGE_FRENCH_SWISS
fallback on
 LANGUAGE_FRENCH
*
Make
 LANGUAGE_ITALIAN_SWISS
fallback on
 LANGUAGE_ITALIAN
*
Astonishing that this haven't been done already.

Original comment by pg...@yahoo.se on 4 Dec 2011 at 9:00

GoogleCodeExporter commented 9 years ago

Original comment by pg...@yahoo.se on 13 Dec 2011 at 5:47

Attachments:

GoogleCodeExporter commented 9 years ago 
And a fallback for LANGUAGE_DUTCH_BELGIAN onto LANGUAGE_DUTCH,
 in case someone does a dutch translation.

Original comment by pg...@yahoo.se on 15 Dec 2011 at 12:43

Attachments:

GoogleCodeExporter commented 9 years ago 
I see no point to fallback some translations to not yet done translation. 
However I will do the italian update. By the way, people can still choose 
manually the language. It is only an hint for the automatic detection of the 
default language.

Note: it would be easier to attach a patch rather than the complete file.

Original comment by gregory....@gmail.com on 15 Dec 2011 at 8:53

GoogleCodeExporter commented 9 years ago 

Curious about "i18n_IsLegacyLanguageId".
Can this be made?

-------------------------------------------------------------------

// Some of the codes provided by wxWidgets are 'obsolete' -- effectively 
replaced by more specific
// region-qualified language codes.  This function can be used to filter them 
out.
bool i18n_IsLegacyLanguageId( wxLanguage lang )
{
    return
        (lang == wxLANGUAGE_ENGLISH) ||
        (lang == wxLANGUAGE_CHINESE) ||
        (lang == wxLANGUAGE_CHINESE_TRADITIONAL) ||
        (lang == wxLANGUAGE_GERMAN) ||
        (lang == wxLANGUAGE_ITALIAN) ||
        (lang == wxLANGUAGE_SERBIAN) || // ?
        (lang == wxLANGUAGE_SPANISH) ||
        (lang == wxLANGUAGE_SWEDISH);
}

// Multiple language ID are actually mostly identical languages. In case a 
translation is not
// yet provided for the dialect fallback to the main one. It would reduce the 
burden of the
// translators and reduce the language pack.
static wxLanguage i18n_FallbackToAnotherLang( wxLanguage wxLangId )
{
    // if some translations are provided, do not change the language
    LangPackList dummy_lang;
    bool valid_stat = false;
    i18n_DoPackageCheck(wxLangId, dummy_lang, valid_stat);
    if (valid_stat) return wxLangId;

    switch(wxLangId)
    {
        case wxLANGUAGE_CHINESE_HONGKONG  : 
        case wxLANGUAGE_CHINESE_MACAU     : return wxLANGUAGE_CHINESE_TRADITIONAL;
        case wxLANGUAGE_CHINESE_SINGAPORE : return wxLANGUAGE_CHINESE_SIMPLIFIED;
        case wxLANGUAGE_PORTUGUESE        : return wxLANGUAGE_PORTUGUESE_BRAZILIAN;
        default                           : break;
    }
    return wxLangId;
}

-------------------------------------------------------------------

Furthermore, won't the filter in "i18n_IsLegacyLanguageId" remove the 
"_HONGKONG"\"_MACAU"\"_SINGAPORE"
 part of "LANGUAGE_CHINESE", and consequently wrack the Chinese entries in "i18n_FallbackToAnotherLang"?

Original comment by pg...@yahoo.se on 15 Dec 2011 at 9:47

GoogleCodeExporter commented 9 years ago 
And here is two more entries for "i18n_FallbackToAnotherLang":
        case wxLANGUAGE_LOWER_SORBIAN :
        case wxLANGUAGE_UPPER_SORBIAN :
                                            return wxLANGUAGE_GERMAN;
http://en.wikipedia.org/wiki/Sorbian_languages

Original comment by pg...@yahoo.se on 15 Dec 2011 at 10:26

GoogleCodeExporter commented 9 years ago 
And five more:
        case wxLANGUAGE_IRISH :
        case wxLANGUAGE_WELSH :
                                            return wxLANGUAGE_ENGLISH;
        case wxLANGUAGE_SAMI_LULE_SWEDEN :
        case wxLANGUAGE_SAMI_NORTHERN_SWEDEN :
        case wxLANGUAGE_SAMI_SOUTHERN_SWEDEN :
                                            return wxLANGUAGE_SWEDISH;

Original comment by pg...@yahoo.se on 17 Dec 2011 at 2:48

GoogleCodeExporter commented 9 years ago 
My two cents: I think you should compile all related changes in source that you 
want to suggest and provide a file result of "svn diff" in pcsx2 SVN source. I 
bet it would be easier for developers to read it.

Original comment by rafael.f...@gmail.com on 17 Dec 2011 at 2:59

GoogleCodeExporter commented 9 years ago 
Canceling the suggestion for IRISH & WELSH fallbacks.
If the language support isn't there,
 then english is implemented anyway.

Original comment by pg...@yahoo.se on 17 Dec 2011 at 7:31

GoogleCodeExporter commented 9 years ago 
Better late than never I found that these strings,
 used in the "PCSX2 Program Log"\"Sources" menu, are missing in translation:
 - "EE Consol"
 - "IOP Consol"
 - "EErec Performance"
 - "SysVM Control Events"
 - "pxThread"
Any comment?

Original comment by pg...@yahoo.se on 28 Dec 2011 at 5:40

GoogleCodeExporter commented 9 years ago 
Three strings in the translationfiles are missing "®" after "Playstation".
Should it be added?

File: \SVN\pcsx2\CDVD\CDVD.cpp
Line: 391-392
    L"Playstation game discs are not supported by PCSX2.  If you want to emulate PSX games "
    L"then you'll have to download a PSX-specific emulator, such as ePSXe or PCSX."
ought to be:
    L"Playstation® game discs are not supported by PCSX2.  If you want to emulate PSX games "
    L"then you'll have to download a PSX-specific emulator, such as ePSXe or PCSX."
or even better:
    L"PlayStation® game discs are not supported by PCSX2.  If you want to emulate PSX games "
    L"then you'll have to download a PSX-specific emulator, such as ePSXe or PCSX."

File: \SVN\pcsx2\gui\Dialogs\FirstTimeWizard.cpp
Line: 141-143
    L"PCSX2 requires a *legal* copy of the PS2 BIOS in order to run games.\n"
    L"You cannot use a copy obtained from a friend or the Internet.\n"
    L"You must dump the BIOS from your *own* Playstation 2 console."
ought to be:
    L"PCSX2 requires a *legal* copy of the PS2 BIOS in order to run games.\n"
    L"You cannot use a copy obtained from a friend or the Internet.\n"
    L"You must dump the BIOS from your *own* Playstation® 2 console."
or even better:
    L"PCSX2 requires a *legal* copy of the PS2 BIOS in order to run games.\n"
    L"You cannot use a copy obtained from a friend or the Internet.\n"
    L"You must dump the BIOS from your *own* PlayStation® 2 console."

File: \SVN\pcsx2\gui\Dialogs\AboutBoxDialog.cpp
Line: 98
    "A Playstation 2 Emulator"
ought to be:
    "A Playstation® 2 Emulator"
or even better:
    "A PlayStation® 2 Emulator"

Original comment by pg...@yahoo.se on 30 Dec 2011 at 4:36

GoogleCodeExporter commented 9 years ago 
Addition to comment 77:
 "ELF" is also missing in the translation,
  if that could be of relevance to anyone.

Original comment by pg...@yahoo.se on 30 Dec 2011 at 7:11

GoogleCodeExporter commented 9 years ago 
Addition to comment 77:
Another string without translationsupport.
It shows up as title in the PCSX2 program log window.
File: \SVN\pcsx2\gui\AppInit.cpp
Line: 111
L"PCSX2 Program Log"

Original comment by pg...@yahoo.se on 5 Jan 2012 at 11:16

GoogleCodeExporter commented 9 years ago 
Addition to comment 77:

Found three more strings that lacks translationsupport.
File: \SVN\pcsx2\CDVD\CDVDaccess.cpp
Line: 38-40
    L"Iso",
    L"Plugin",
    L"NoDisc",
These strings show up in the SE-corner of the PCSX2 GUI, signifying the current 
CDVD source.

The location of the strings in comment 77 & 79 is
*
"ELF"
"EErec Performance"
"EE Console"
"IOP Console"
File: \SVN\pcsx2\SourceLog.cpp
Line: 95, 100, 105, 110
*
"SysVM Control Events"
File: \SVN\pcsx2\gui\Executorthread.cpp
Line: 39
*
"pxThread"
File: \SVN\common\src\Utilities\ThreadTools.cpp
Line: 40

Original comment by pg...@yahoo.se on 9 Jan 2012 at 9:13

GoogleCodeExporter commented 9 years ago 
An update of the fallbacks is called for since norwegian has been added in the 
forums.
Also added a fallback for dutch (even though it's not supported by a 
translation), and updated passive comments.

Original comment by pg...@yahoo.se on 14 Aug 2012 at 10:27

Attachments:

GoogleCodeExporter commented 9 years ago 
Arabic has also been added in the forums, which calls for fallbackupdates.

Original comment by pg...@yahoo.se on 15 Aug 2012 at 4:36

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by pg...@yahoo.se on 15 Aug 2012 at 6:36

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by pg...@yahoo.se on 15 Aug 2012 at 6:36

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by pg...@yahoo.se on 15 Aug 2012 at 6:39

Attachments:

GoogleCodeExporter commented 9 years ago 
Added a fallback for Corsican to French.

Original comment by pg...@yahoo.se on 15 Aug 2012 at 9:24

Attachments:

GoogleCodeExporter commented 9 years ago 
Added a fallback for Catalan to Spanish.

Original comment by pg...@yahoo.se on 16 Aug 2012 at 2:48

Attachments:

GoogleCodeExporter commented 9 years ago 
Added fallback for Basque to Spanish, since most of it is located in Spain.

Original comment by pg...@yahoo.se on 21 Aug 2012 at 8:01

Attachments:

GoogleCodeExporter commented 9 years ago 
Fixed some errors.
Moved Sami fallback no Norwegian, since most of them live there.
Added fallback for Afrikaans to Dutch (Frisian isn't supported).

Original comment by pg...@yahoo.se on 7 Sep 2012 at 6:49

Attachments:

GoogleCodeExporter commented 9 years ago 
Ok. I apply latest one.

Original comment by gregory....@gmail.com on 8 Sep 2012 at 4:48

GoogleCodeExporter commented 9 years ago 
Fallbacks for:
 • Valencian to Spanish
 • Galician to Brazilian Portuguese
 • Ukraineian Russian to Russian
 • Javanese to Indonesian

Original comment by pg...@yahoo.se on 3 Oct 2012 at 10:53

Attachments:

GoogleCodeExporter commented 9 years ago 
And another one: "MALAY_BRUNEI_DARUSSALAM" to "MALAY_MALAYSIA".

Original comment by pg...@yahoo.se on 4 Oct 2012 at 6:15

Attachments:

GoogleCodeExporter commented 9 years ago 
Corrected some comments.

Original comment by pg...@yahoo.se on 20 Nov 2012 at 7:24

Attachments:

GoogleCodeExporter commented 9 years ago 
New patch request for i18n.
About the same as the previous (which wasn't applied), except now Norwegian 
(and thereby also Sami and Danish) fallbacks on Swedish,
 since the Norwegian translation is really bad because of misunderstanding (assumably) by the translator of how to use Iconized,
 and the translator doesn't seem to be interested in improving the translation with the new simpler Iconized.

Please also update my sv_SE. :)

Original comment by pg...@yahoo.se on 12 Apr 2013 at 8:45

Attachments:

GoogleCodeExporter commented 9 years ago 
Not worth the attention, huh? :(

Original comment by pg...@yahoo.se on 29 Apr 2013 at 2:36

GoogleCodeExporter commented 9 years ago 
Translations must be the most boring aspect of emu coding ever. Don't be 
surprised when no one picks this up to fill their brief emu coding dedicated 
time slot :)

Original comment by ramapcsx2.code on 30 Apr 2013 at 7:13

GoogleCodeExporter commented 9 years ago 
Would be possible to update the patch to keep only real change and drop 
formatting stuff. I would realign all : in my text editor.

Note: I don't want to replace Norwegian by Swedish by default. It won't 
stimulate people to complete the translation.

Original comment by gregory....@gmail.com on 1 May 2013 at 9:42

GoogleCodeExporter commented 9 years ago 
I made a new version of the patch, if your interested.
Can't make GitHub work so I post it here.

Changes:
Disabled Sami and Danish fallbacks on Norwegian since the Norwegian translation 
is to incomplete.
Disabled other Sami fallbacks since it's to problematic.
Added Galician fallback to Portuguese_Brazilian.
Added Russian_Ukraine fallback to Russian.
Added Javanese fallback to Indonesian.
Added Malay_Brunei_Darussalam fallback to Malay_Malaysia.
Added Frisian fallback to Dutch (now supported by wxWidget).

Original comment by pg...@yahoo.se on 7 Jun 2014 at 6:14

Attachments: